Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add grid elevation ground filter #154

Merged
merged 2 commits into from
Oct 17, 2022

Conversation

tkimura4
Copy link
Collaborator

@tkimura4 tkimura4 commented Oct 14, 2022

Description

autowarefoundation#1899
Hotfix to beta/v0.5.2-odaiba

To merge this PR, another PR is needed. so We well merge this one too.

(Note: autowarefoundation#1614 does not affect Autoware behavior.)

Related Links

https://github.com/tier4/autoware_launch.xx1/pull/337

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

badai-nguyen and others added 2 commits October 14, 2022 13:20
* fix(ray_ground_filter): cannot remove ground pcl

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: remove base_frame

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* docs: update docs

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* chores: remove unnecessary calculation

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* chores: remove unnecessary calculation

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* docs: update parameters

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* docs: update parameters

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
…oundation#1899)

* fix: add grid elevation scan ground filter

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* chore: typo

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: merge with scan ground filter

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* ci(pre-commit): autofix

* chore: update docs

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* chore: remove debug variables

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* chore: add switchable param for grid scan mode

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* chore: typo

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* chore: refactoring

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* ci(pre-commit): autofix

* chore: refactoring

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* chore: typo

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* chore: refactoring

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* chore: refactoring

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* chore: refactoring

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* chore: refactoring

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* chore: refactoring

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* chore: typo

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* docs: update docs

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* ci(pre-commit): autofix

* chore: typo

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* chores: typo

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* chore: typo

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* docs: update

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@tkimura4
Copy link
Collaborator Author

Related PR: tier4/autoware_launch#509

@tkimura4 tkimura4 requested review from miursh and removed request for yukke42 October 14, 2022 04:26
@tkimura4 tkimura4 changed the title Hotfix/add grid elevation ground filter feat: add grid elevation ground filter Oct 14, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2022

Codecov Report

❗ No coverage uploaded for pull request base (beta/v0.5.2-odaiba@9676275). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@                 Coverage Diff                  @@
##             beta/v0.5.2-odaiba    #154   +/-   ##
====================================================
  Coverage                      ?   0.00%           
====================================================
  Files                         ?       5           
  Lines                         ?     725           
  Branches                      ?       0           
====================================================
  Hits                          ?       0           
  Misses                        ?     725           
  Partials                      ?       0           
Flag Coverage Δ
differential 0.00% <0.00%> (?)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tkimura4
Copy link
Collaborator Author

This PR is ready for merge.
(with https://github.com/tier4/autoware_launch.xx1/pull/337 )

@tkimura4 tkimura4 marked this pull request as ready for review October 17, 2022 03:18
@tkimura4 tkimura4 requested a review from shmpwk October 17, 2022 06:44
@tkimura4 tkimura4 merged commit ba1bfca into beta/v0.5.2-odaiba Oct 17, 2022
@tkimura4 tkimura4 deleted the hotfix/add_grid_elevation_ground_filter branch October 17, 2022 06:58
tkimura4 pushed a commit that referenced this pull request Oct 24, 2022
* update topic name

* update namespace
maxime-clem pushed a commit to maxime-clem/autoware.universe that referenced this pull request Feb 7, 2024
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants