feat(hazard_lights_selector): turn on hazard lights from mrm comfortable stop operator #323

mkuri · 2023-03-16T11:06:46Z

Description

https://tier4.atlassian.net/browse/T4PB-22513

Add hazard_lights_selector so that hazard lights can be directed from nodes other than behavior_path_planner

Related PR

https://github.com/tier4/autoware_launch.x2/pull/258

Before

After

Test
緩停止MRMを発動させて/planning/hazard_lights_cmdのcommandが2 (=ENABLE)をpublishすること

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

I've confirmed the contribution guidelines.
The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>

…ackage Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>

… state Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>

codecov-commenter · 2023-03-16T11:22:57Z

Codecov Report

❗ No coverage uploaded for pull request base (beta/v0.6.1@3f563c7). Click here to learn what that means.
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

@@              Coverage Diff               @@
##             beta/v0.6.1     #323   +/-   ##
==============================================
  Coverage               ?   10.58%           
==============================================
  Files                  ?     1248           
  Lines                  ?    90031           
  Branches               ?    20802           
==============================================
  Hits                   ?     9532           
  Misses                 ?    70412           
  Partials               ?    10087

Flag	Coverage Δ		*Carryforward flag
differential	`0.00% <0.00%> (?)`
total	`10.56% <0.00%> (?)`		Carriedforward from 39c3948

*This pull request uses carry forward flags. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

TomohitoAndo

I confirmed this works.

simplescreenrecorder-2023-03-17_10.08.22.mp4

TomohitoAndo · 2023-03-17T01:39:05Z

@mkuri
I think this is irrelevant with this PR, I found that the vehicle sometimes can't stop with MRM comfortable stop. 🥺

simplescreenrecorder-2023-03-17_10.32.57.mp4

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>

mkuri · 2023-03-17T07:49:53Z

@TomohitoAndo

I think this is irrelevant with this PR, I found that the vehicle sometimes can't stop with MRM comfortable stop.

I'll fix this issue in a separate PR

…ortable-stop

TomohitoAndo · 2023-03-23T00:55:50Z

pre-commit.ci run

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

TomohitoAndo · 2023-03-23T02:49:02Z

@mkuri
I added pre-commit fixes and this can be merged now.

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

…ble stop operator (#323) * chore(hazard_lights_selector): add the hazard_lights_selector package Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com> * chore(hazard_lights_selector): implement a header file Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com> * chore(hazard_lights_selector): implement the hazard_lights_selector package Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com> * chore(hazard_lights_selector): remove a current hazard lights command state Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com> * refacotr(hazard_lights_selector): remove extra lines Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com> * feat(mrm_comfortable_stop_operator): add hazard lights publisher Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com> * chore(hazard_lights_selector): add a maintainer Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com> * style: pre-commit fixes Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> --------- Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com> Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> Co-authored-by: Tomohito Ando <tomohito.ando@tier4.jp>

* feat(hazard_lights_selector): turn on hazard lights from mrm comfortable stop operator (#323) * chore(hazard_lights_selector): add the hazard_lights_selector package Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com> * chore(hazard_lights_selector): implement a header file Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com> * chore(hazard_lights_selector): implement the hazard_lights_selector package Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com> * chore(hazard_lights_selector): remove a current hazard lights command state Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com> * refacotr(hazard_lights_selector): remove extra lines Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com> * feat(mrm_comfortable_stop_operator): add hazard lights publisher Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com> * chore(hazard_lights_selector): add a maintainer Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com> * style: pre-commit fixes Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> --------- Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com> Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> Co-authored-by: Tomohito Ando <tomohito.ando@tier4.jp> * migrate to latest Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> --------- Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com> Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> Co-authored-by: Makoto Kurihara <mkuri8m@gmail.com> Co-authored-by: Tomohito Ando <tomohito.ando@tier4.jp>

mkuri added 6 commits March 15, 2023 11:17

chore(hazard_lights_selector): add the hazard_lights_selector package

ba505cd

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>

chore(hazard_lights_selector): implement a header file

f6c35b0

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>

chore(hazard_lights_selector): implement the hazard_lights_selector p…

47b39b4

…ackage Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>

chore(hazard_lights_selector): remove a current hazard lights command…

4152031

… state Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>

refacotr(hazard_lights_selector): remove extra lines

b486df2

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>

feat(mrm_comfortable_stop_operator): add hazard lights publisher

b4de3bc

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>

github-actions bot added documentation Improvements or additions to documentation planning system labels Mar 16, 2023

mkuri requested review from TomohitoAndo and 0x126 March 16, 2023 11:10

TomohitoAndo approved these changes Mar 17, 2023

View reviewed changes

mkuri changed the title ~~Feature/turn on hazard lights at comfortable stop~~ feat(hazard_lights_selector): turn on hazard lights from mrm comfortable stop operator Mar 17, 2023

chore(hazard_lights_selector): add a maintainer

5b96bdf

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>

mkuri added 2 commits March 17, 2023 16:51

Merge branch 'beta/v0.6.1' into feature/turn-on-hazard-lights-at-comf…

39c3948

…ortable-stop

Merge branch 'beta/v0.6.1' into feature/turn-on-hazard-lights-at-comf…

eb85d99

…ortable-stop

style: pre-commit fixes

7ebd7f9

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

mkuri merged commit ccd1688 into tier4:beta/v0.6.1 Mar 24, 2023

maxime-clem pushed a commit to maxime-clem/autoware.universe that referenced this pull request Feb 7, 2024

refactor(ansible): install Docker Compose using apt (tier4#323)

554d6b8

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(hazard_lights_selector): turn on hazard lights from mrm comfortable stop operator #323

feat(hazard_lights_selector): turn on hazard lights from mrm comfortable stop operator #323

mkuri commented Mar 16, 2023 •

edited

Loading

codecov-commenter commented Mar 16, 2023 •

edited

Loading

TomohitoAndo left a comment •

edited

Loading

TomohitoAndo commented Mar 17, 2023

mkuri commented Mar 17, 2023 •

edited

Loading

TomohitoAndo commented Mar 23, 2023

TomohitoAndo commented Mar 23, 2023

feat(hazard_lights_selector): turn on hazard lights from mrm comfortable stop operator #323

feat(hazard_lights_selector): turn on hazard lights from mrm comfortable stop operator #323

Conversation

mkuri commented Mar 16, 2023 • edited Loading

Description

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

Post-review checklist for the PR author

codecov-commenter commented Mar 16, 2023 • edited Loading

Codecov Report

TomohitoAndo left a comment • edited Loading

Choose a reason for hiding this comment

TomohitoAndo commented Mar 17, 2023

mkuri commented Mar 17, 2023 • edited Loading

TomohitoAndo commented Mar 23, 2023

TomohitoAndo commented Mar 23, 2023

mkuri commented Mar 16, 2023 •

edited

Loading

codecov-commenter commented Mar 16, 2023 •

edited

Loading

TomohitoAndo left a comment •

edited

Loading

mkuri commented Mar 17, 2023 •

edited

Loading