Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dummy diag publisher): change diag name specification method to YAML #2840 #367

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

0x126
Copy link

@0x126 0x126 commented Apr 19, 2023

Description

cherry-pick
autowarefoundation#2840

Related links

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

…YAML (autowarefoundation#2840)

* Signed-off-by: asana17 <akihiro.sakurai@tier4.jp>

modified dummy_diag_publisher to use YAML for param

* Signed-off-by: asana17 <akihiro.sakurai@tier4.jp>

use YAML param for dummy_diag_publisher

* fix empty param

Signed-off-by: asana17 <akihiro.sakurai@tier4.jp>

* fixed empty param

Signed-off-by: asana17 <akihiro.sakurai@tier4.jp>

* fix spelling

Signed-off-by: asana17 <kei17.kaight084@gmail.com>

* add pkg maintainer

Signed-off-by: asana17 <akihiro.sakurai@tier4.jp>

* launch dummy_diag_publisher by launch_dummy_diag_publisher param

Signed-off-by: asana17 <akihiro.sakurai@tier4.jp>

---------

Signed-off-by: asana17 <akihiro.sakurai@tier4.jp>
@github-actions github-actions bot added documentation Improvements or additions to documentation launch system labels Apr 19, 2023
@0x126 0x126 changed the title feat(dummy diag publisher): change diag name specification method to YAML feat(dummy diag publisher): change diag name specification method to YAML #2840 Apr 19, 2023
@0x126 0x126 marked this pull request as ready for review April 19, 2023 13:19
@0x126 0x126 merged commit eb46ca9 into beta/v0.6.1 Apr 20, 2023
@0x126 0x126 deleted the feat/update-dummy-diag branch April 20, 2023 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation launch system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants