fix(intersection): always send finite distance to occlusion peeking stop line in RTC #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…op line when occlusion is detected (autowarefoundation#3528) * a bit refactored Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * start waiting at the first stop line when isVehicleStopped() Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * start waiting when vehicle is stopped when near the stop line Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * merge autowarefoundation#3529 Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> --------- Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
* always set RTC distance to default stop line/occlusion stop line Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * initialize RTC status as non occluded at intersection module construction Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * removed debug print Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * keep waiting at 1st stop lineif externally occlusion is requested Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> --------- Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…arefoundation#3552) fixed to restart after occlusion disappeared Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…on#3553) clear costmap on adjacent lanes Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…top line in RTC (autowarefoundation#3573) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin
requested review from
kosuke55,
kyoichi-sugahara,
mkuri,
maxime-clem,
satoshi-ota,
shmpwk,
taikitanaka3,
takayuki5168,
TomohitoAndo,
tkimura4 and
purewater0901
as code owners
Codecov ReportPatch coverage has no change and project coverage change:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## beta/v0.8.0 #405 +/- ##
==============================================
- Coverage 3.45% 3.44% -0.01%
==============================================
Files 99 99
Lines 7468 7485 +17
Branches 4084 4099 +15
==============================================
Hits 258 258
- Misses 7016 7033 +17
Partials 194 194
☔ View full report in Codecov by Sentry. |
shmpwk
approved these changes
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
死角頭出しラインまでの距離が非承認時にも有限の値になるよう修正
Same as autowarefoundation#3573
Related links
Tests performed
uuidの確認
uuid.mp4
有死角時の動作の確認
default.mp4
非承認時のRTCと壁の確認
RTC.mp4
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.