Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ndt_scan_matcher): ndt_scan_matcher crash when input cloud is empty. (#3354) #502

Merged
merged 2 commits into from
May 26, 2023

Conversation

h-ohta
Copy link

@h-ohta h-ohta commented May 19, 2023

Description

autowarefoundation#3354 のbackport
一部Throttleのdurationを1000に変更(durationはミリ秒指定なので)

Tests performed

変更内容に上記記載以外相違がないこと

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…ty. (autowarefoundation#3354)

* Fixed NDTScanMatcher crash when input cloud is empty.

* style(pre-commit): autofix

---------

Co-authored-by: Zygfryd Wieszok <zwieszok@autonomous-systems.pl>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: M(-_-)Sakamoto <83898149+Motsu-san@users.noreply.github.com>
Copy link

@v-nojiri7841-esol v-nojiri7841-esol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

バックポート元との違いは、フォーマッターによる改行位置の修正のみであり、バックポート元の変更が取り込まれている。パッケージビルドもOK。

@h-ohta h-ohta merged commit 9e47abb into beta/v0.3.16 May 26, 2023
@h-ohta h-ohta deleted the backport/3354 branch May 26, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants