-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(obstacle_cruise_planner): make slow down feature stabler #505
Conversation
…owarefoundation#3743) * feat(obstacle_cruise_planner): hysteresis for slow down decision Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update config Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…efoundation#3751) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…ts (autowarefoundation#3744) * fix(obstacle_cruise_planner): insert slow down with precise constraints Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…3778) * feat(obstacle_cruise_planner): stabler slow down Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * use min when inserting slow down Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix slow down appearing twice Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update param Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…oundation#3747) * fix(motion_utils): fix logic to calculate decel distantace Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * max_dec -> min_acc Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * max_dec -> min_acc Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…oundation#3775) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## beta/v0.8.0 #505 +/- ##
===============================================
- Coverage 15.06% 15.05% -0.01%
===============================================
Files 1412 1412
Lines 99191 99317 +126
Branches 29844 29897 +53
===============================================
+ Hits 14939 14950 +11
- Misses 68193 68292 +99
- Partials 16059 16075 +16
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
障害物に対する減速機能の安定化
以下のmain内のコミットをcherry-pick
Tests performed
※3, 4件ほどfailが増えているスイートがありますがだいたい確認済みで、シナリオ修正が必須です
PRマージ後に対応していきます 🙏
Effects on system behavior
slow down機能の安定化
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.