Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(obstacle_cruise_planner): make slow down feature stabler #505

Merged
merged 6 commits into from
May 21, 2023

Conversation

takayuki5168
Copy link

@takayuki5168 takayuki5168 commented May 21, 2023

Description

障害物に対する減速機能の安定化
以下のmain内のコミットをcherry-pick

Tests performed

※3, 4件ほどfailが増えているスイートがありますがだいたい確認済みで、シナリオ修正が必須です
 PRマージ後に対応していきます 🙏

Effects on system behavior

slow down機能の安定化

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…owarefoundation#3743)

* feat(obstacle_cruise_planner): hysteresis for slow down decision

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update config

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…ts (autowarefoundation#3744)

* fix(obstacle_cruise_planner): insert slow down with precise constraints

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…3778)

* feat(obstacle_cruise_planner): stabler slow down

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* use min when inserting slow down

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix slow down appearing twice

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update param

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…oundation#3747)

* fix(motion_utils): fix logic to calculate decel distantace

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* max_dec -> min_acc

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* max_dec -> min_acc

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…oundation#3775)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168
Copy link
Author

@tkimura4 @shmpwk
月火の前車追従/slow down機能に関するリリース評価において、こちらのコミットも込みで実験していただきたいです
シナリオテスト確認済みでPRとしてはマージレディです、マージ後に3件ほど増えたfailのシナリオ側の修正をしていきます

@codecov-commenter
Copy link

codecov-commenter commented May 21, 2023

Codecov Report

Patch coverage: 11.00% and project coverage change: -0.01 ⚠️

Comparison is base (59fc3a0) 15.06% compared to head (94cc1bb) 15.05%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@               Coverage Diff               @@
##           beta/v0.8.0     #505      +/-   ##
===============================================
- Coverage        15.06%   15.05%   -0.01%     
===============================================
  Files             1412     1412              
  Lines            99191    99317     +126     
  Branches         29844    29897      +53     
===============================================
+ Hits             14939    14950      +11     
- Misses           68193    68292      +99     
- Partials         16059    16075      +16     
Flag Coverage Δ *Carryforward flag
differential 19.94% <11.00%> (+0.16%) ⬆️
total 13.89% <ø> (-0.01%) ⬇️ Carriedforward from 59fc3a0

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
common/signal_processing/src/lowpass_filter_1d.cpp 86.66% <0.00%> (-13.34%) ⬇️
..._planner/utils/avoidance/avoidance_module_data.hpp 0.00% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 18.99% <0.00%> (+0.02%) ⬆️
...ehavior_path_planner/src/utils/avoidance/utils.cpp 5.89% <0.00%> (-0.12%) ⬇️
...avior_path_planner/src/utils/lane_change/utils.cpp 0.97% <ø> (+<0.01%) ⬆️
...lude/obstacle_cruise_planner/planner_interface.hpp 14.08% <0.00%> (-5.15%) ⬇️
planning/obstacle_cruise_planner/src/node.cpp 13.05% <0.00%> (-0.22%) ⬇️
.../obstacle_cruise_planner/src/planner_interface.cpp 8.98% <0.00%> (-2.63%) ⬇️
planning/behavior_path_planner/src/utils/utils.cpp 20.00% <36.36%> (+0.30%) ⬆️
...n/motion_utils/test/src/distance/test_distance.cpp 57.14% <50.00%> (ø)
... and 2 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shmpwk shmpwk merged commit a4cb529 into beta/v0.8.0 May 21, 2023
@shmpwk shmpwk deleted the tmp/murooka/slow-down-update3 branch May 21, 2023 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants