Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert(distortion corrector_node): performance tuning (#2913) #512

Merged

Conversation

1222-takeshi
Copy link

@1222-takeshi 1222-takeshi commented May 23, 2023

This reverts commit b72ca85.

Description

特定の条件でvelodyne_node_containerが落ちるので一旦こちらのコミットはrevertします。
image

Related links

autowarefoundation#2913

Tests performed

revert前で落ちていたシナリオで落ちないことを確認した
Autoware Evaluator

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Copy link
Collaborator

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😢

@tkimura4 tkimura4 merged commit 19a8b0a into beta/v0.8.0 May 23, 2023
@tkimura4 tkimura4 deleted the revert/distortion-corrector-performance-tuning branch May 23, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants