Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): fix simultaneous execution #725

Merged
merged 3 commits into from
Aug 16, 2023

Conversation

kosuke55
Copy link

@kosuke55 kosuke55 commented Aug 14, 2023

Description

cherry-pick and resolve conflict
autowarefoundation#4622

Related links

https://tier4.atlassian.net/browse/RT1-3390

Tests performed

failed scenario test

 webauto ci scenario run --project-id x2_dev --scenario-id 94ca41a5-67bf-427c-acc2-c2534195f8e7 --runtime-path . --scenario-parameters __tier4_modifier_ego_speed=2.7778,__tier4_modifier_inter_vehicular_distance=0,__tier4_modifier_npc_speed=2.7778,__tier4_modifier_spawntime=3,__tier4_modifier_prepare_time=1
lc_fixed_goal_x2-2023-08-14_19.08.25.mp4

Notes for reviewers

please set enable_simultaneous_execution_as_approved_module: true in lanechange if using x2 branch

    lane_change_left:
      enable_module: true
      enable_rtc: true
      enable_simultaneous_execution_as_approved_module: true
      enable_simultaneous_execution_as_candidate_module: false
      priority: 6
      max_module_size: 1

    lane_change_right:
      enable_module: true
      enable_rtc: true
      enable_simultaneous_execution_as_approved_module: true
      enable_simultaneous_execution_as_candidate_module: false
      priority: 6
      max_module_size: 1

Interface changes

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@saka1-s saka1-s changed the base branch from beta/v0.9.0 to beta/v0.9.1 August 16, 2023 00:29
@saka1-s saka1-s enabled auto-merge (squash) August 16, 2023 00:30
Copy link

@saka1-s saka1-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
The PR was tested on my local.

@saka1-s saka1-s merged commit 9bb2a61 into beta/v0.9.1 Aug 16, 2023
10 of 11 checks passed
@saka1-s saka1-s deleted the fix/fixed_goal_planner_execution_v0.9.0 branch August 16, 2023 00:31
kosuke55 added a commit that referenced this pull request Aug 22, 2023
* fix(behavior_path_planner): fix simultaneous execution

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix for v0.9.0

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix typo

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

---------

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 added a commit that referenced this pull request Aug 22, 2023
* fix(behavior_path_planner): fix simultaneous execution

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix for v0.9.0

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix typo

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

---------

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

remove setIsSimultaneousExecutableAs from start_planner to fix build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants