Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): [TO BE REVERTED] set max velocity #738

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

rej55
Copy link

@rej55 rej55 commented Aug 17, 2023

Description

The lane change module can not know the final planned velocity, so the safety check in lane change may be broken.
This is the temporary fix for this issue.

THIS CHANGE WILL BE REVERTED.

Related links

Tests performed

Tested in real vehicle

Notes for reviewers

Interface changes

Nothing.

Effects on system behavior

The max lane change speed will be restricted to 40 km/h.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Copy link
Collaborator

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!!!!

@tkimura4 tkimura4 merged commit 6ed12a1 into beta/v0.10.0 Aug 17, 2023
10 checks passed
@tkimura4 tkimura4 deleted the fix/lane_change_max_speed branch August 17, 2023 04:29
rej55 added a commit that referenced this pull request Aug 22, 2023
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants