Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sonar): sonar cloud coverage #1452

Merged
merged 5 commits into from
Nov 18, 2024
Merged

fix(sonar): sonar cloud coverage #1452

merged 5 commits into from
Nov 18, 2024

Conversation

chris-tier4
Copy link
Contributor

@chris-tier4 chris-tier4 commented Nov 14, 2024 •
edited by hakuturu583
Loading

Description

Replace buggy custom gcov script with gcovr

Abstract

Current gcov coverage uploaded to sonar cloud excludes coverage where it was covered, this PR fixes it.

Background

Details

Some of the gcov settings, etc. were not covered due to improper settings.
Fixed to collect gcov records using gcovr.

References

https://star4.slack.com/archives/C04TZBEABDM/p1730968513939279?thread_ts=1727660826.478009&cid=C04TZBEABDM

Destructive Changes

N/A

Known Limitations

N/A

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 14, 2024 •
edited by hakuturu583
Loading

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@chris-tier4 chris-tier4 marked this pull request as draft November 15, 2024 01:41
@chris-tier4 chris-tier4 marked this pull request as ready for review November 15, 2024 04:45
@chris-tier4
chore: add gcov upload to CI
8e2ad59 
chore: BuildAndRun debug

test: try with inline flags

test: gcovr

test: sonar with gcov full run

test: add debug branch trigger

fix: gcovr output file

update dict

Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
@chris-tier4
debug
2d0295b 
no-inline

no-inline

test: remove unncessary debug

test: remove extra flags

debug witout inline
@chris-tier4
chore: remove unneeded debug
18b17f6
@chris-tier4 chris-tier4 force-pushed the fix/sonar-cloud-coverage-chris branch from 46dbc69 to 18b17f6 Compare November 15, 2024 08:05
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@hakuturu583 hakuturu583 merged commit bbe0fa0 into master Nov 18, 2024
13 checks passed
@hakuturu583 hakuturu583 added the bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 label Nov 18, 2024
@github-actions github-actions bot deleted the fix/sonar-cloud-coverage-chris branch November 18, 2024 01:27
@github-actions github-actions bot restored the fix/sonar-cloud-coverage-chris branch November 18, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakuturu583 hakuturu583 hakuturu583 approved these changes

Assignees

@chris-tier4 chris-tier4

Labels
bump patch If this pull request merged, bump patch version of the scenario_simulator_v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chris-tier4 @hakuturu583