Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/interpreter #1463

Merged
merged 6 commits into from
Nov 29, 2024
Merged

Refactor/interpreter #1463

merged 6 commits into from
Nov 29, 2024

Conversation

yamacir-kit
Copy link
Collaborator

@yamacir-kit yamacir-kit commented Nov 28, 2024

Description

Abstract

The following minor changes were made to the interpreter code:

  • The implementation of the file-local function hypot, which switches dimensions depending on the parameter considier_pose_by_road_slope (the same function was copied to multiple files), was made into a single free function.
  • Old descriptions that remained in the documentation for the syntax Entities were deleted.

Background

None.

Details

None.

References

None.

Destructive Changes

None.

Known Limitations

None.

Signed-off-by: yamacir-kit <httperror@404-notfound.jp>
Signed-off-by: yamacir-kit <httperror@404-notfound.jp>
Signed-off-by: yamacir-kit <httperror@404-notfound.jp>
Signed-off-by: yamacir-kit <httperror@404-notfound.jp>
@yamacir-kit yamacir-kit added the bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 label Nov 28, 2024
@yamacir-kit yamacir-kit self-assigned this Nov 28, 2024
Copy link

github-actions bot commented Nov 28, 2024

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

Signed-off-by: yamacir-kit <httperror@404-notfound.jp>
Copy link

@yamacir-kit yamacir-kit marked this pull request as ready for review November 29, 2024 05:38
@yamacir-kit yamacir-kit requested a review from HansRobo November 29, 2024 05:38
@HansRobo HansRobo assigned HansRobo and unassigned yamacir-kit Nov 29, 2024
@yamacir-kit yamacir-kit merged commit cd36f0b into master Nov 29, 2024
15 checks passed
@github-actions github-actions bot deleted the refactor/interpreter branch November 29, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants