Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/distance condition #1467

Merged
merged 8 commits into from
Dec 4, 2024
Merged

Conversation

yamacir-kit
Copy link
Collaborator

@yamacir-kit yamacir-kit commented Dec 2, 2024

Description

Abstract

Added a static member function version of DistanceCondition::evaluate.

Background

The static version of DistanceCondition::evaluate is useful for implementing TimeToCollisionCondition, so we implemented it.

Details

None.

References

None.

Destructive Changes

None.

Known Limitations

None.

@yamacir-kit yamacir-kit added refactor bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 labels Dec 2, 2024
@yamacir-kit yamacir-kit self-assigned this Dec 2, 2024
Copy link

github-actions bot commented Dec 2, 2024

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

Signed-off-by: yamacir-kit <httperror@404-notfound.jp>
Signed-off-by: yamacir-kit <httperror@404-notfound.jp>
Signed-off-by: yamacir-kit <httperror@404-notfound.jp>
Signed-off-by: yamacir-kit <httperror@404-notfound.jp>
@yamacir-kit yamacir-kit requested a review from HansRobo December 4, 2024 07:42
@yamacir-kit yamacir-kit marked this pull request as ready for review December 4, 2024 07:42
@yamacir-kit yamacir-kit merged commit 7eda26e into master Dec 4, 2024
16 checks passed
@github-actions github-actions bot deleted the refactor/distance-condition branch December 4, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants