Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in math::geometry::getClosestPoses #1475

Merged
merged 9 commits into from
Dec 17, 2024
Merged

Conversation

f0reachARR
Copy link
Contributor

Description

Abstract

Fix bug in math::geometry::getClosestPoses. The bug is explained in #1332

Details

This PR also added some test cases for math::geometry::getClosestPoses

References

#1332

@f0reachARR f0reachARR changed the title Fix/math closest point Fix bug in math::geometry::getClosestPoses Dec 5, 2024
Copy link

github-actions bot commented Dec 5, 2024

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@HansRobo HansRobo linked an issue Dec 5, 2024 that may be closed by this pull request
@HansRobo HansRobo added bug Something isn't working bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 wait for regression test labels Dec 10, 2024
@HansRobo HansRobo self-requested a review December 11, 2024 09:23
@HansRobo HansRobo marked this pull request as ready for review December 11, 2024 09:23
Copy link
Member

@HansRobo HansRobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with no regression.

But, waiting for internal team now.

@HansRobo
Copy link
Member

The internal team confirmation has finished.
I'll merge this after all CIs are finished.

@HansRobo HansRobo merged commit 1b94a71 into master Dec 17, 2024
14 checks passed
@github-actions github-actions bot deleted the fix/math-closest-point branch December 17, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working bump patch If this pull request merged, bump patch version of the scenario_simulator_v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incomplete implementation of math::geometry::getClosestPoses function
2 participants