-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/multi level lanelet support #1481
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enhanced lanelet matching algorithm (`toLaneletPose` method) by incorporating lanelet altitude. - Defined the `altitude_threshold` parameter that sets the maximum altitude difference to determine when an entity can be matched with a specific lanelet.
- Enhanced BehaviorTree to consider altitude when detecting potential obstacles, allowing to ignore objects located at different altitudes. - Modified the detection sensor by introducing Ego plane determination to exclude objects below the Ego plane, preventing unnecessary slowing or stopping caused by incorrect detections.
SzymonParapura
added
the
bump minor
If this pull request merged, bump minor version of the scenario_simulator_v2
label
Dec 9, 2024
Checklist for reviewers ☑️All references to "You" in the following text refer to the code reviewer.
|
- Updated the makeRandomPose method to correctly support 3D lanelet matching.
SzymonParapura
added
wait for regression test
and removed
wait for regression test
labels
Dec 9, 2024
…com/tier4/scenario_simulator_v2 into feature/multi-level-lanelet-support
…ensure proper logic
SzymonParapura
added
wait for regression test
and removed
wait for regression test
labels
Dec 11, 2024
There is no regresssion |
Quality Gate passedIssues Measures |
HansRobo
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Abstract
This pull request introduces support for multi-level lanelets (e.g., bridges over roads) by improving lanelet matching and collision solving mechanisms. Previously, lanelet matching relied on 2D position checks, which could lead to incorrect detections and false-positive collisions when entities were on different altitudes.
Background
In multi-level environments – such as maps featuring bridges over roads or tunnels beneath roads – the previous lanelet matching and collision detection algorithms relied solely on 2D proximity checks. This approach considered only the X and Y coordinates of entities, ignoring their altitude (Z-axis).
As a result, entities located on different levels (e.g., a vehicle on a bridge and another vehicle on the road below) could be incorrectly matched to the same lanelet. This caused:
To resolve these issues, 3D lanelet matching and collision-solving mechanisms have been introduced.
Details
Enhancements to Lanelet Matching
3D Matching Support
New
altitude_threshold
ParameterImprovements to Collision Solving
BehaviorTree Updates
Ego Plane Determination
Geometry Enhancements
Plane
structure and methods to calculate offsets relative to this plane. Link to introduced changes.Fix traffic_source class
TrafficSource::makeRandomPose
method does not account for the Z-axis when generating random positions. As a result, the generated position may be incorrect and an entity may not match to the lanelet. To fix this issue, the Z-coordinate is now assigned based on the altitude of the first nearby lanelet found. Link to introduced changesFix Unit tests
References
Internal link 1
Internal link 2
Destructive Changes
--
Known Limitations
--