-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add external api adaptor for calibration status #43
feat: add external api adaptor for calibration status #43
Conversation
Signed-off-by: TakumiKozaka-T4 <takumi.kozaka@tier4.jp>
Signed-off-by: TakumiKozaka-T4 <takumi.kozaka@tier4.jp>
@TakumiKozaka-T4 Please add api name to description. |
I added api name and brief summary. |
@TakumiKozaka-T4 Cc: @isamu-takagi |
@yabuta |
Fixed review procedure for calibration status. |
…i_adaptor into feature/add_calibration_status
Signed-off-by: TakumiKozaka-T4 <takumi.kozaka@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…i_adaptor into feature/add_calibration_status
Signed-off-by: TakumiKozaka-T4 <takumi.kozaka@tier4.jp>
* (editting) save current work Signed-off-by: TakumiKozaka-T4 <takumi.kozaka@tier4.jp> * fix bug and run pre-commit Signed-off-by: TakumiKozaka-T4 <takumi.kozaka@tier4.jp> * pull the latest tier4/universe Signed-off-by: TakumiKozaka-T4 <takumi.kozaka@tier4.jp> * pull the latest tier4/univerese Signed-off-by: TakumiKozaka-T4 <takumi.kozaka@tier4.jp> (cherry picked from commit 7cb94a5)
PR Type
Related Links
autowarefoundation/autoware.universe#722
Description
Add external api adapter for calibration data related to the linked PR.
This adapter provides the following items.
Calibration status (currently only accel_brake_map calibration status is included)
This returns plot and new accel brake map suggested by autoware
Review Procedure
Test for calibration status
Open three terminal and run the following.
ros2 topic echo /api/external/get/calibration_status
Calibration status will be published as follows.
Test for the server
Open two terminal and run the following.
"plot.svg" should be created in the directory you run the server.
The directory "test_data_save" should be created. It include "accel_map.csv"", "brake_map.csv" and "graph.svg".
Remarks
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks