Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add external api adaptor for calibration status #43

Merged
merged 6 commits into from
Jun 15, 2022

Conversation

TakumiKozaka-T4
Copy link
Contributor

@TakumiKozaka-T4 TakumiKozaka-T4 commented May 26, 2022

PR Type

  • New Feature

Related Links

autowarefoundation/autoware.universe#722

Description

Add external api adapter for calibration data related to the linked PR.
This adapter provides the following items.

  • ROS Topic : /api/external/get/calibration_status
    Calibration status (currently only accel_brake_map calibration status is included)
  • ROS Service : /api/external/get/accel_brake_map_calibrator/data
    This returns plot and new accel brake map suggested by autoware

Review Procedure

Test for calibration status
Open three terminal and run the following.

  • Terminal 1 : Run planning simulator
  • Terminal 2 : Launch accel_brake_map_calibrator
  • Terminal 3 : ros2 topic echo /api/external/get/calibration_status

Calibration status will be published as follows.

stamp:
sec: 1653529613
nanosec: 71053510
status_array:
target: 1
status: 0

Test for the server
Open two terminal and run the following.

  • Terminal for server : ros2 run accel_brake_map_calibrator plot_csv_server_node.py
    "plot.svg" should be created in the directory you run the server.
  • Terminal for client : ros2 run accel_brake_map_calibrator plot_csv_server_node.py
    The directory "test_data_save" should be created. It include "accel_map.csv"", "brake_map.csv" and "graph.svg".

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR / build-and-test-pr: Required to pass before the merge.
  • Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s).
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

Signed-off-by: TakumiKozaka-T4 <takumi.kozaka@tier4.jp>
Signed-off-by: TakumiKozaka-T4 <takumi.kozaka@tier4.jp>
@yabuta
Copy link
Contributor

yabuta commented May 26, 2022

@TakumiKozaka-T4 Please add api name to description.

@TakumiKozaka-T4
Copy link
Contributor Author

I added api name and brief summary.

@yabuta
Copy link
Contributor

yabuta commented May 27, 2022

@TakumiKozaka-T4 Cc: @isamu-takagi
Do you add this api to document?

@TakumiKozaka-T4
Copy link
Contributor Author

@yabuta
Not yet. I'll add this later.

@TakumiKozaka-T4
Copy link
Contributor Author

Fixed review procedure for calibration status.
(Changed topic name from "/accel_brake_map_calibrator/output/calibration_status" to "/api/external/get/calibration_status")

Signed-off-by: TakumiKozaka-T4 <takumi.kozaka@tier4.jp>
@TakumiKozaka-T4 TakumiKozaka-T4 changed the title Add external api adaptor for calibration status feat: add external api adaptor for calibration status Jun 14, 2022
Copy link
Contributor

@yabuta yabuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: TakumiKozaka-T4 <takumi.kozaka@tier4.jp>
@TakumiKozaka-T4 TakumiKozaka-T4 merged commit 7cb94a5 into tier4/universe Jun 15, 2022
@TakumiKozaka-T4 TakumiKozaka-T4 deleted the feature/add_calibration_status branch June 15, 2022 06:40
Youneko pushed a commit that referenced this pull request Jun 16, 2022
* (editting) save current work

Signed-off-by: TakumiKozaka-T4 <takumi.kozaka@tier4.jp>

* fix bug and run pre-commit

Signed-off-by: TakumiKozaka-T4 <takumi.kozaka@tier4.jp>

* pull the latest tier4/universe

Signed-off-by: TakumiKozaka-T4 <takumi.kozaka@tier4.jp>

* pull the latest tier4/univerese

Signed-off-by: TakumiKozaka-T4 <takumi.kozaka@tier4.jp>
(cherry picked from commit 7cb94a5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants