VSR/Sync: Allow tables to queue for sync twice #1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timeline of the VOPR seed in #1273 (seed `2812334640525749465` on commit `47c03651ff08ee547b4baefda1b5b40f7f95e191 `): 1. Replica 2: Superblock sync completes. Begin syncing LSM tables. 2. Replica 2: Queue the table `address=62 checksum=145957321580082356891479597489273601427 level=0` for sync (`GridBlocksMissing.enqueue_table()`). 3. Replica 2: LSM compaction moves the table with `address=62` to level 1. 4. Replica 2: Queue the table `address=62 checksum=145957321580082356891479597489273601427 level=1` for sync (`GridBlocksMissing.enqueue_table()`). The `ForestTableIterator` doesn't repeat tables... except when the table in question has moved to the next level� This commit loosens the assertion to allow for this case. Fixes #1273.
matklad
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timeline of the VOPR seed in #1273 (seed
2812334640525749465on commit47c03651ff08ee547b4baefda1b5b40f7f95e191):address=62 checksum=145957321580082356891479597489273601427 level=0for sync (GridBlocksMissing.enqueue_table()).address=62to level 1.address=62 checksum=145957321580082356891479597489273601427 level=1for sync (GridBlocksMissing.enqueue_table()).The
ForestTableIteratordoesn't repeat tables... except when the table in question has moved to the next level.This commit loosens the assertion to allow for this case.
Fixes #1273.