cache_map: speed up fuzzing #1904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cb22
reviewed
May 1, 2024
src/lsm/cache_map_fuzz.zig
Outdated
Comment on lines
274
to
280
| fn copy_hash_map(dst: *Map, src: *Map) !void { | ||
| dst.clearRetainingCapacity(); | ||
| var it = src.iterator(); | ||
| while (it.next()) |kv| { | ||
| try dst.putNoClobber(kv.key_ptr.*, kv.value_ptr.*); | ||
| } | ||
| } |
There was a problem hiding this comment.
Indeed, fixed, and also sneaked in some zebra stripes
There was a problem hiding this comment.
just so the latest commit is clearly visible
|
Slightly better than my copy-the-entire hash map 😄 |
HashMap model doesn't support scopes in an efficient manner. Use HashMap + UndoLog to fix this. The following seed now finishes in 5 seconds in debug Seed: ./zig/zig build fuzz -- --seed=5311370176449483187 lsm_cache_map
matklad
force-pushed
the
matklad/fuzz-cachemap
branch
from
72111f9 to
46026a8
Compare
cb22
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HashMap model doesn't support scopes in an efficient manner. Use HashMap + UndoLog to fix this.
The following seed now finishes in 5 seconds in debug
Seed: ./zig/zig build fuzz -- --seed=5311370176449483187 lsm_cache_map