-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge child class fillable traits with those of the parent class #120
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great code; just a few code style notes, which I think we can solve in the future by running Duster on the codebase and then using that for future code style.
src/HasParent.php
Outdated
|
||
|
||
/** | ||
* Merge the fillable attributes for the model with Parent Class |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Merge the fillable attributes for the model with Parent Class | |
* Merge the fillable attributes for the model with those of its Parent Class |
src/HasParent.php
Outdated
*/ | ||
public function getFillable() | ||
{ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete this extra line please.
Highlights
References