Set default slack webhook url in example env to localhost #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omarrida
requested review from
mattstauffer and
driftingly
and removed request for
mattstauffer
|
I think both changes are good. Thanks! |
mattstauffer
deleted the
ozr/set-default-slack-webhook-url-to-localhost-in-example-env
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Cloning the repo for the first time and following the usual steps (migrate, key:generate, etc) along with the contributing instructions doesn't result in a green test suite. The
StatsTestwill fail onthe_slack_notification_is_sent()because the webhook url doesn't match the.envfile. To fix this and get green, the contributor has to diagnose the test failure and then set theirSLACK_WEBHOOK_URLtohttp://localhost.Solution
Two changes are introduced in this PR:
SLACK_WEBHOOK_URLin the example env.Note that either one of these changes will fix the issue, so if it's preferable I'm happy to reduce this PR to only one of the two proposed changes.