Encode boolean query parameters as integers #345
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how we handle query parameters so that boolean values are encoded as integers in the query string. We do this by passing a custom encoder function to
qs.stringify()
that casts booleans to numbers (and ignores everything else).Before
After
Motivation
route()
helper, which also encodes booleans as integers in query strings.boolean
validation rule, which only recognizestrue
,false
,0
,1
,"0"
, and"1"
.Closes #340.