add missing metrics

Signed-off-by: cfzjywxk <lsswxrxr@163.com>
tikv · Mar 2, 2023 · a89c575 · a89c575
1 parent 35aa78e
commit a89c575
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/metrics/shortcuts.go b/metrics/shortcuts.go
@@ -86,6 +86,7 @@ var (
 	TxnRegionsNumHistogramPessimisticLock              prometheus.Observer
 	TxnRegionsNumHistogramPessimisticRollbackInternal  prometheus.Observer
 	TxnRegionsNumHistogramPessimisticRollback          prometheus.Observer
+	TxnRegionsNumHistogramWithCoprocessorInternal      prometheus.Observer
 	TxnRegionsNumHistogramWithCoprocessor              prometheus.Observer
 	TxnRegionsNumHistogramWithBatchCoprocessorInternal prometheus.Observer
 	TxnRegionsNumHistogramWithBatchCoprocessor         prometheus.Observer
@@ -209,10 +210,14 @@ func initShortcuts() {
 	TxnRegionsNumHistogramPessimisticLock = TiKVTxnRegionsNumHistogram.WithLabelValues("2pc_pessimistic_lock", LblGeneral)
 	TxnRegionsNumHistogramPessimisticRollbackInternal = TiKVTxnRegionsNumHistogram.WithLabelValues("2pc_pessimistic_rollback", LblInternal)
 	TxnRegionsNumHistogramPessimisticRollback = TiKVTxnRegionsNumHistogram.WithLabelValues("2pc_pessimistic_rollback", LblGeneral)
-	TxnRegionsNumHistogramWithBatchCoprocessorInternal = TiKVTxnRegionsNumHistogram.WithLabelValues("coprocessor", LblInternal)
+	TxnRegionsNumHistogramWithCoprocessorInternal = TiKVTxnRegionsNumHistogram.WithLabelValues("coprocessor", LblInternal)
+	TxnRegionsNumHistogramWithCoprocessor = TiKVTxnRegionsNumHistogram.WithLabelValues("coprocessor", LblGeneral)
+	TxnRegionsNumHistogramWithBatchCoprocessorInternal = TiKVTxnRegionsNumHistogram.WithLabelValues("batch_coprocessor", LblInternal)
 	TxnRegionsNumHistogramWithBatchCoprocessor = TiKVTxnRegionsNumHistogram.WithLabelValues("batch_coprocessor", LblGeneral)
 	TxnWriteKVCountHistogramInternal = TiKVTxnWriteKVCountHistogram.WithLabelValues(LblInternal)
 	TxnWriteKVCountHistogramGeneral = TiKVTxnWriteKVCountHistogram.WithLabelValues(LblGeneral)
+	TxnWriteSizeHistogramInternal = TiKVTxnWriteSizeHistogram.WithLabelValues(LblInternal)
+	TxnWriteSizeHistogramGeneral = TiKVTxnWriteSizeHistogram.WithLabelValues(LblGeneral)
 
 	LockResolverCountWithBatchResolve = TiKVLockResolverCounter.WithLabelValues("batch_resolve")
 	LockResolverCountWithExpired = TiKVLockResolverCounter.WithLabelValues("expired")

diff --git a/txnkv/transaction/2pc.go b/txnkv/transaction/2pc.go
@@ -697,7 +697,7 @@ func (c *twoPhaseCommitter) initKeysAndMutations(ctx context.Context) error {
 		ResolveLock: util.ResolveLockDetail{},
 	}
 
-	isInternalReq := util.IsInternalRequest(c.txn.GetRequestSource())
+	isInternalReq := c.txn.isInternal()
 	if isInternalReq {
 		metrics.TxnWriteKVCountHistogramInternal.Observe(float64(commitDetail.WriteKeys))
 		metrics.TxnWriteSizeHistogramInternal.Observe(float64(commitDetail.WriteSize))