txn: add newly inserted flag for memdb key node #337
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sticnarf
reviewed
Oct 14, 2021
longfangsong
approved these changes
Oct 15, 2021
|
Point get and batch point get use |
Signed-off-by: cfzjywxk <lsswxrxr@163.com>
cfzjywxk
force-pushed
the
support_newly_inserted_flag
branch
from
e030651
to
9090b5f
Compare
|
can we merge this? cc @cfzjywxk |
|
Closing it to prevent distractions. Please reopen it when we want to advance. |
|
@disksing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution for pingcap/tidb#27564.
Add a new flag for key in
memdb, when the key node is allocated by aPUToperation, add this flag to the key. This mark is used to identify the inserted keys generated from the transaction iteself, so that the delete operations on these unlocked keys could be skipped committing this transaction, see the comments for details in the issue.This change could be risky, need to think it over.