Add gRPC connection monitor and fix related bug #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Smityz <smityz@qq.com>
Signed-off-by: Smityz <smityz@qq.com>
|
@hicqu @MyonKeminta Please take a look. |
hicqu
reviewed
Jan 16, 2023
|
@hicqu any more comments? |
hicqu
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Smityz smityz@qq.com
fix: #522 #653
After a tikv server restart, the grpc connection state on the client becomes IDLE and needs a request to be sent through this connection or a manual connect to change it to the READY state. In the current implementation, I believe trying to
Connect()when the state is IDLE is a relatively small modification.And add a monitor of grpc connection state can help us to find related bugs