kvrpc: deduplicate chained intercept by name #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>
nolouch
reviewed
Jun 9, 2023
| @@ -903,6 +903,7 @@ func (s *KVSnapshot) SetRPCInterceptor(it interceptor.RPCInterceptor) { | |||
| } | |||
|
|
|||
| // AddRPCInterceptor adds an interceptor, the order of addition is the order of execution. | |||
| // the chained interceptors will be dedupcated by its name. | |||
There was a problem hiding this comment.
Currently, the same interceptor is set in different places in tidb, I'm not sure if they are set several times because the current behavior is replace. But I want to change the behavior to add
nolouch
approved these changes
Jun 9, 2023
Signed-off-by: glorv <glorvs@163.com>
Connor1996
reviewed
Jun 13, 2023
| @@ -122,29 +153,49 @@ func NewRPCInterceptorChain() *RPCInterceptorChain { | |||
| // Link is used to link the next RPCInterceptor. | |||
| // Multiple interceptors will be executed in the order of link time. | |||
There was a problem hiding this comment.
add a comment about the behavior of linking duplicated interceptor
Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deduplicate chained intercept by name so we can replace SetInterceptor with AddInterceptor