make ResourceControlInterceptor atomic #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: glorv <glorvs@163.com>
|
@nolouch @Connor1996 PTAL |
hawkingrei
approved these changes
Jun 20, 2023
|
@disksing PTAL |
|
test failed |
|
/merge |
12 tasks
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref pingcap/tidb#44818
pingcap/tidb#44819 is another attempt to fix the race but the test still failed https://do.pingcap.net/jenkins/job/pingcap/job/tidb/job/ghpr_unit_test/26946/display/redirect.
while in theory, we can init the
ResourceControlInterceptoronce when the server is bootstrapped. But due to some implementation restriction, it's hard to do so in tidb and the current code can case data race though the data race is harmless.So this PR changes the type to atomic ptr for simplicity.