- changes after review

Signed-off-by: Ionut Slaveanu <ionut.slaveanu@adswizz.com>

.github/workflows/ci.yml

@@ -12,7 +12,7 @@ on:
 env:
   RUST_BACKTRACE: 1
   # Some of the bindgen tests generate "deref-nullptr" warnings, see https://github.com/rust-lang/rust-bindgen/issues/1651
-  RUSTFLAGS: "--deny=warnings --allow deref-nullptr --allow renamed_and_removed_lints"
+  RUSTFLAGS: "--deny=warnings --allow deref-nullptr"
   TEST_BIND: 1
   GRPC_VERBOSITY: "info"
 

Cargo.toml

@@ -14,7 +14,7 @@ categories = ["asynchronous", "network-programming"]
 autoexamples = false
 
 [package.metadata.docs.rs]
-all-features = true 
+all-features = true
 
 [dependencies]
 grpcio-sys = { path = "grpc-sys", version = "0.13.0", default-features = false }

health/src/lib.rs

@@ -31,6 +31,7 @@
 //! assert_eq!(statuss_resp.status, ServingStatus::Serving);
 //! ```
 
+#[allow(renamed_and_removed_lints)]
 pub mod proto;
 mod service;
 

interop/Cargo.toml

@@ -8,8 +8,7 @@ publish = false
 default = ["protobuf-codec"]
 protobuf-codec = ["protobuf", "grpcio/protobuf-codec", "grpcio-proto/protobuf-codec"]
 protobufv3-codec = ["protobufv3", "grpcio/protobufv3-codec", "grpcio-proto/protobufv3-codec"]
-_secure = []
-openssl = ["_secure", "grpcio-sys/openssl"]
+openssl = []
 
 [dependencies]
 grpcio = { path = "..", default-features = false, features = ["boringssl"]}

proto/src/lib.rs

@@ -1,5 +1,6 @@
 // Copyright 2019 TiKV Project Authors. Licensed under Apache-2.0.
 
+#[allow(renamed_and_removed_lints)]
 mod proto;
 
 #[cfg(any(feature = "protobuf-codec", feature = "protobufv3-codec"))]

src/metadata.rs

@@ -185,7 +185,6 @@ impl Metadata {
     /// Returns the metadata entry at the `index`.
     ///
     /// `None` is returned if out of bound.
-    #[allow(clippy::unnecessary_cast)]
     pub fn get(&self, index: usize) -> Option<(&str, &[u8])> {
         if self.0.count <= index {
             return None;
@@ -195,7 +194,7 @@ impl Metadata {
             let key = grpc_sys::grpcwrap_metadata_array_get_key(&self.0, index, &mut key_len);
             let val = grpc_sys::grpcwrap_metadata_array_get_value(&self.0, index, &mut val_len);
             let key_str = str::from_utf8_unchecked(slice::from_raw_parts(key as _, key_len));
-            let val_bytes = slice::from_raw_parts(val as *const u8, val_len);
+            let val_bytes = slice::from_raw_parts(val.cast(), val_len);
             Some((key_str, val_bytes))
         }
     }