Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpc-sys: Use grpc headers found by pkgconfig. #505

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

grpc-sys: Use grpc headers found by pkgconfig. #505

wants to merge 3 commits into from

Commits on Dec 28, 2020

  1. grpc-sys: Use grpc headers found by pkgconfig. 

    Previously the bundled grpc headers were always used to generate
bindings even in the case where pkgconfig was used to locate gRPC to
link against. This caused errors at runtime, e.g., SEGFAULT, rather than
a compile-time error. To fix this, use the headers found by pkgconfig to
generate bindings rather than than the bundled headers if pkgconfig is
already being used.

Signed-off-by: Steven Sloboda <ssloboda@starry.com>
    @ssloboda
    ssloboda committed Dec 28, 2020
    Configuration menu
    Copy the full SHA
    2c15028 View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2020

  1. fixup! grpc-sys: Use grpc headers found by pkgconfig.

    @ssloboda
    ssloboda committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    3465dde View commit details
    Browse the repository at this point in the history

  2. grpc-sys: fix typo in build script error messsage. 

    Signed-off-by: Steven Sloboda <ssloboda@starry.com>
    @ssloboda
    ssloboda committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    cc29ee2 View commit details
    Browse the repository at this point in the history