Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary warnings_into_errors #611

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

puzzle-rusher
Copy link

I ran into a problem when I tried to compile this project. cc stops compilation when 184 warnings are encountered, while allowing a maximum of 20 errors.
Warning: turning warnings into errors only make sense if you are a developer of the crate using cc-rs. Some warnings only appear on some architecture or specific version of the compiler. Any user of this crate, or any other crate depending on it, could fail during compile time.

@BusyJay
Copy link
Member

BusyJay commented Feb 17, 2023

grpc_wrap.cc is maintained by the project, it's expected to be no warnings. Can you paste the actual warnings?

@puzzle-rusher
Copy link
Author

grpc_wrap.cc is maintained by the project, it's expected to be no warnings. Can you paste the actual warnings?

https://gist.github.com/puzzle-rusher/fee086d8b370965c76134c7943bd745b

@puzzle-rusher
Copy link
Author

puzzle-rusher commented Feb 17, 2023

grpc_wrap.cc is maintained by the project, it's expected to be no warnings. Can you paste the actual warnings?

I think this is wrong behavior anyway, if the cc library warns you of this possibility, you should heed them. I spent a lot of time to find the reason why I can't compile my project which has a transitive dependency on your project, I don't want anyone to waste time on this.

@BusyJay
Copy link
Member

BusyJay commented Feb 17, 2023

The warnings are generated by the builtin headers instead of any code from grpc-rs. It means your compiler might not match the headers. I can see there is a similar issue in other project, maybe you can try similar solutions. golang/go#38876

@puzzle-rusher
Copy link
Author

The warnings are generated by the builtin headers instead of any code from grpc-rs. It means your compiler might not match the headers. I can see there is a similar issue in other project, maybe you can try similar solutions. golang/go#38876

It's a common situation. And it's not the reason to prohibit using your library, don't you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants