Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdc,chore: Fail to bump grpc 1.59 #371

Closed
pingyu opened this issue Nov 29, 2023 · 0 comments · Fixed by #372
Closed

cdc,chore: Fail to bump grpc 1.59 #371

pingyu opened this issue Nov 29, 2023 · 0 comments · Fixed by #372
Labels
type/bug Something isn't working

Comments

@pingyu
Copy link
Collaborator

pingyu commented Nov 29, 2023

Bug Report

1. Describe the bug

https://github.com/tikv/migration/actions/runs/7000026869/job/19040096570?pr=353

go: github.com/tikv/migration/cdc/cdc/kv tested by
	github.com/tikv/migration/cdc/cdc/kv.test imports
	github.com/pingcap/tidb/store/mockstore/mockcopr tested by
	github.com/pingcap/tidb/store/mockstore/mockcopr.test imports
	github.com/pingcap/tidb/domain imports
	github.com/pingcap/tidb/domain/infosync tested by
	github.com/pingcap/tidb/domain/infosync.test imports
	go.etcd.io/etcd/tests/v3/integration imports
	go.etcd.io/etcd/pkg/v3/grpc_testing imports
	google.golang.org/grpc/test/grpc_testing: module google.golang.org/grpc@latest found (v1.59.0), but does not contain package google.golang.org/grpc/test/grpc_testing
make: *** [Makefile:[143](https://github.com/tikv/migration/actions/runs/7000026869/job/19040096570?pr=353#step:4:144): tidy] Error 1

2. Minimal reproduce step (Required)

3. What did you see instead (Required)

4. What did you expect to see? (Required)

5. What is your migration tool and TiKV version? (Required)

  • TiKV:
  • TiKV CDC: main (1736954)
  • TiKV BR:
  • TiKV Online Bulk Load:
@pingyu pingyu added the type/bug Something isn't working label Nov 29, 2023
pingyu added a commit that referenced this issue Dec 4, 2023
* upgrade golangci v1.55.2

Signed-off-by: Ping Yu <yuping@pingcap.com>

* fix lint error

Signed-off-by: Ping Yu <yuping@pingcap.com>

---------

Signed-off-by: Ping Yu <yuping@pingcap.com>
pingyu added a commit that referenced this issue Dec 4, 2023
* upgrade client-go/tidb to release 7.5

Signed-off-by: Ping Yu <yuping@pingcap.com>

* try

Signed-off-by: Ping Yu <yuping@pingcap.com>

* polish

Signed-off-by: Ping Yu <yuping@pingcap.com>

* upgrade golangci v1.55.2

Signed-off-by: Ping Yu <yuping@pingcap.com>

* fix lint error

Signed-off-by: Ping Yu <yuping@pingcap.com>

---------

Signed-off-by: Ping Yu <yuping@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant