-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[close #324] Switch to official client-go 44449c0 #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ping Yu <yuping@pingcap.com>
Signed-off-by: Ping Yu <yuping@pingcap.com>
Signed-off-by: Ping Yu <yuping@pingcap.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #368 +/- ##
================================================
+ Coverage 61.0955% 61.5201% +0.4246%
================================================
Files 240 240
Lines 20283 20195 -88
================================================
+ Hits 12392 12424 +32
+ Misses 6771 6653 -118
+ Partials 1120 1118 -2
*This pull request uses carry forward flags. Click here to find out more.
|
Signed-off-by: Ping Yu <yuping@pingcap.com>
pingyu
changed the title
[close #324] Switch to official client-go v2.0.7
[close #324] Switch to official client-go 44449c0
Nov 19, 2023
Signed-off-by: Ping Yu <yuping@pingcap.com>
zeminzhou
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #324
Problem Description: Use official release of client-go
What is changed and how does it work?
Switch to official
client-go
commit 44449c0526f2a524b8cfc8b0fb3343046b73e6e8, which is the same with latest TiDB LTS release-7.1The latest release of
client-go
v2.0.7 has not been updated for a while and has some known issues.Code changes
Check List for Tests
This PR has been tested by at least one of the following methods:
Side effects
Related changes
To reviewers
Please follow these principles to check this pull requests:
(The above text mainly refers to TiDB Development Guide. It's also highly recommended to read about Writing code review comments)