Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast timeout operator when leader changed #2493

Closed
nolouch opened this issue Jun 3, 2020 · 2 comments · Fixed by #2530
Closed

Fast timeout operator when leader changed #2493

nolouch opened this issue Jun 3, 2020 · 2 comments · Fixed by #2530
Assignees
Labels
component/schedule Scheduling logic. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. priority/release-blocker This issue blocks a release. Please solve it ASAP. type/enhancement The issue or PR belongs to an enhancement.
Milestone

Comments

@nolouch
Copy link
Contributor

nolouch commented Jun 3, 2020

Feature Request

Describe your feature request related problem:

If the leader changed cause by TiKV(maybe too busy or network problem), the operator cannot step to the final state, such as

PD:
try to remove peer 24
TiKV:
reject remove peer 24 because it is a leader.

Then the operator needs 10mins to timeout, which may cause the rule sync learner became slow.

Describe the feature you'd like:

Describe alternatives you've considered:

We can check if the peer is the leader then fast timeout the operator.

Teachability, Documentation, Adoption, Migration Strategy:

  • Go
@nolouch nolouch added type/enhancement The issue or PR belongs to an enhancement. component/schedule Scheduling logic. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Jun 3, 2020
@disksing
Copy link
Contributor

disksing commented Jun 3, 2020

Looks too tricky. How about TiKV attach some info in heartbeat to cancel the operator explicitly?

@nolouch
Copy link
Contributor Author

nolouch commented Jun 3, 2020

In my patch, I will check the step safety before sending it to TiKV. If the step is to remove the peer and the region leader is the same as the peer, we can cancel the operator. but it only solves this one situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/schedule Scheduling logic. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. priority/release-blocker This issue blocks a release. Please solve it ASAP. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants