operator: fast-fail if the leader changed to the RemovePeer #2530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nolouch <nolouch@gmail.com>
nolouch
added
component/schedule
rleungx
reviewed
Jun 11, 2020
Codecov Report
@@ Coverage Diff @@
## master #2530 +/- ##
==========================================
+ Coverage 77.06% 77.09% +0.03%
==========================================
Files 204 204
Lines 22079 22044 -35
==========================================
- Hits 17015 16995 -20
+ Misses 3773 3769 -4
+ Partials 1291 1280 -11
Continue to review full report at Codecov.
|
rleungx
approved these changes
Jun 16, 2020
disksing
reviewed
Jun 16, 2020
| func (oc *OperatorController) checkStaleOperator(op *operator.Operator, step operator.OpStep, region *core.RegionInfo) bool { | ||
| switch s := step.(type) { | ||
| case operator.RemovePeer: | ||
| if s.FromStore == region.GetLeader().GetStoreId() { |
There was a problem hiding this comment.
I think it's too tricky to make special judgments on removePeer and leader here. Maybe we can solve it by recording the expected region leader at each step and check if the leader is the same. (like op.ConfVerChanged)
rleungx
reviewed
Jun 16, 2020
lhy1024
reviewed
Jun 16, 2020
Signed-off-by: nolouch <nolouch@gmail.com>
rleungx
reviewed
Jun 17, 2020
disksing
reviewed
Jun 17, 2020
Signed-off-by: nolouch <nolouch@gmail.com>
disksing
approved these changes
Jun 18, 2020
|
/merge |
1 similar comment
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
cherry pick to release-3.0 failed |
|
cherry pick to release-3.1 failed |
|
cherry pick to release-4.0 failed |
nolouch
added a commit
to nolouch/pd
that referenced
this pull request
Jun 18, 2020
Signed-off-by: nolouch <nolouch@gmail.com>
ti-srebot
pushed a commit
that referenced
this pull request
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: nolouch nolouch@gmail.com
What problem does this PR solve?
Fix #2493
If the leader changed cause by TiKV(maybe too busy or network problem), the operator cannot step to the final state, such as
Then the operator needs 10mins to timeout, which may cause the rule sync learner became slow.
What is changed and how it works?
Check List
Tests
Release note