Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delta() should not be used in counter #4489

Closed
rleungx opened this issue Dec 22, 2021 · 1 comment · Fixed by #7669
Closed

delta() should not be used in counter #4489

rleungx opened this issue Dec 22, 2021 · 1 comment · Fixed by #7669
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. severity/moderate type/bug The issue is confirmed as a bug.

Comments

@rleungx
Copy link
Member

rleungx commented Dec 22, 2021

Bug Report

According to https://prometheus.io/docs/prometheus/latest/querying/functions/#delta: "delta should only be used with gauges".
But we have some counters that use the delta function which may cause the wrong results. These metrics can be found in pd.json.

What did you see instead?

Like previous issue: #3561

Another one is the region heartbeat in the test cluster:
Screen Shot 2021-12-22 at 5 10 43 PM

What version of PD are you using (pd-server -V)?

master
@rleungx rleungx added the type/bug The issue is confirmed as a bug. label Dec 22, 2021
@rleungx rleungx changed the title delta() should not be used in counter delta() should not be used in counter Dec 22, 2021
@rleungx rleungx added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Dec 22, 2021
@BenMusch
Copy link

BenMusch commented Mar 4, 2022

Hi! I'm onboarding to TiDB at work and trying to ramp up to PD. I'm happy to take this as a first issue. Let me know if I need to do anything to assign to myself

@BenMusch BenMusch mentioned this issue Mar 4, 2022
Closed
@lhy1024 lhy1024 mentioned this issue Jan 4, 2024
Merged
ti-chi-bot bot added a commit that referenced this issue Mar 14, 2024
@lhy1024 @ti-chi-bot
metrics: convert delta() usage to rate(), except for directional nega…
b9ea01a 
…tive (#7669)

close #4489

Signed-off-by: lhy1024 <admin@liudos.us>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. severity/moderate type/bug The issue is confirmed as a bug.
Projects
Questions and Bug Reports
Status: Closed
Milestone
No milestone
3 participants
@jebter @BenMusch @rleungx