Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcdutil: add watch loop tool #6391

Closed
lhy1024 opened this issue Apr 26, 2023 · 0 comments · Fixed by #6390
Closed

etcdutil: add watch loop tool #6391

lhy1024 opened this issue Apr 26, 2023 · 0 comments · Fixed by #6390
Labels
type/development The issue belongs to a development tasks

Comments

@lhy1024
Copy link
Contributor

lhy1024 commented Apr 26, 2023

Development Task

There are some similar code with etcd watch loop:

  1. pd/pkg/tso/keyspace_group_manager.go

    Line 463 in 400e3bd

    func (kgm *KeyspaceGroupManager) watchKeyspaceGroupsMetaChange(revision int64) (int64, error) {

  2. pd/pkg/keyspace/tso_keyspace_group.go

    Line 299 in 400e3bd

    func (m *GroupManager) watchServiceAddrs(ctx context.Context, revision int64) (int64, error) {

  3. pd/server/server.go

    Line 1772 in 400e3bd

    func (s *Server) watchServicePrimaryAddr(ctx context.Context, serviceName string, revision int64) (nextRevision int64, err error) {

  4. pd/server/keyspace_service.go

    Line 72 in 400e3bd

    func (s *KeyspaceServer) WatchKeyspaces(request *keyspacepb.WatchKeyspacesRequest, stream keyspacepb.Keyspace_WatchKeyspacesServer) error {
@lhy1024 lhy1024 added the type/development The issue belongs to a development tasks label Apr 26, 2023
@lhy1024 lhy1024 mentioned this issue Apr 26, 2023
Merged
@ti-chi-bot ti-chi-bot bot closed this as completed in #6390 May 8, 2023
ti-chi-bot bot pushed a commit that referenced this issue May 8, 2023
@lhy1024
etcdutil: add watch loop (#6390)
99742e9 
close #6391

Signed-off-by: lhy1024 <admin@liudos.us>
zeminzhou pushed a commit to zeminzhou/pd that referenced this issue May 8, 2023
@lhy1024 @zeminzhou
etcdutil: add watch loop (tikv#6390)
019dc93 
close tikv#6391

Signed-off-by: lhy1024 <admin@liudos.us>
zeminzhou pushed a commit to zeminzhou/pd that referenced this issue May 10, 2023
@lhy1024 @zeminzhou
etcdutil: add watch loop (tikv#6390)
69d6467 
close tikv#6391

Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
rleungx pushed a commit to rleungx/pd that referenced this issue Aug 2, 2023
@lhy1024 @rleungx
etcdutil: add watch loop (tikv#6390)
e949c32 
close tikv#6391

Signed-off-by: lhy1024 <admin@liudos.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/development The issue belongs to a development tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

etcdutil: add watch loop lhy1024/pd
1 participant
@lhy1024