Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete the old tso microservice discovery when switching away from API mode #6543

Closed
binshi-bing opened this issue Jun 1, 2023 · 0 comments · Fixed by #6544
Closed

Delete the old tso microservice discovery when switching away from API mode #6543

binshi-bing opened this issue Jun 1, 2023 · 0 comments · Fixed by #6544
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@binshi-bing
Copy link
Contributor

Enhancement Task

When switching from the PD mode to the API mode, the old tso microservice discovery isn't needed anymore and all resources can be released to avoid noisy error logs when the component trying to discovery the non-existent tso microservice.
@binshi-bing binshi-bing added the type/enhancement The issue or PR belongs to an enhancement. label Jun 1, 2023
@binshi-bing binshi-bing mentioned this issue Jun 1, 2023
Merged
@ti-chi-bot ti-chi-bot bot closed this as completed in #6544 Jun 1, 2023
ti-chi-bot bot pushed a commit that referenced this issue Jun 1, 2023
@binshi-bing
mcs, tso: delete the tso ms discovery when switching away from API mo…
672f4dc 
…de. (#6544)

close #6543

When switching from the PD mode to the API mode, the old tso microservice discovery isn't needed anymore,
and all resources can be released to avoid noisy error logs when the component trying to discover
the non-existent tso microservice.

Signed-off-by: Bin Shi <binshi.bing@gmail.com>
@binshi-bing binshi-bing changed the title Delete the old tso microservice discovery when switch away from API mode Delete the old tso microservice discovery when switching away from API mode Jun 1, 2023
rleungx pushed a commit to rleungx/pd that referenced this issue Aug 2, 2023
@binshi-bing @rleungx
mcs, tso: delete the tso ms discovery when switching away from API mo…
ec5bba8 
…de. (tikv#6544)

close tikv#6543

When switching from the PD mode to the API mode, the old tso microservice discovery isn't needed anymore,
and all resources can be released to avoid noisy error logs when the component trying to discover
the non-existent tso microservice.

Signed-off-by: Bin Shi <binshi.bing@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

mcs, tso: delete the tso ms discovery when switching away from API mode. binshi-bing/pd
1 participant
@binshi-bing