Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide an interface to merge all keyspace groups into the default one #6756

Closed
JmPotato opened this issue Jul 5, 2023 · 0 comments · Fixed by #6782
Closed

Provide an interface to merge all keyspace groups into the default one #6756

JmPotato opened this issue Jul 5, 2023 · 0 comments · Fixed by #6782
Labels
component/keyspace Key space. component/tso Timestamp Oracle. type/enhancement The issue or PR belongs to an enhancement.

Comments

@JmPotato
Copy link
Member

JmPotato commented Jul 5, 2023 •
edited
Loading

Ref #6589.

Enhancement Task

The current merge operation only supports manually specifying multiple keyspace groups to merge. It would be nice to provide an interface to merge all keyspace groups into the default one easily, which should be a convenient method to do the rollback online.
@JmPotato JmPotato added type/enhancement The issue or PR belongs to an enhancement. component/tso Timestamp Oracle. component/keyspace Key space. labels Jul 5, 2023
@JmPotato JmPotato mentioned this issue Jul 5, 2023
Merged
ti-chi-bot bot added a commit that referenced this issue Jul 10, 2023
@JmPotato @ti-chi-bot
keyspace, tso, apiv2: impl the interface to merge all keyspace groups…
906850b 
… into the default (#6757)

ref #6756

Impl the interface to merge all keyspace groups into the default.

Signed-off-by: JmPotato <ghzpotato@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@JmPotato JmPotato mentioned this issue Jul 10, 2023
Merged
ti-chi-bot bot pushed a commit that referenced this issue Jul 11, 2023
@JmPotato
pd-ctl, tests: impl the merge all keyspace groups command (#6782)
e18b9be 
close #6756

- Impl the merge all keyspace groups command.
- Further reuse of TSO cluster-related test code.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
rleungx pushed a commit to rleungx/pd that referenced this issue Aug 2, 2023
@JmPotato @ti-chi-bot @rleungx
keyspace, tso, apiv2: impl the interface to merge all keyspace groups…
d66e82d 
… into the default (tikv#6757)

ref tikv#6756

Impl the interface to merge all keyspace groups into the default.

Signed-off-by: JmPotato <ghzpotato@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
rleungx pushed a commit to rleungx/pd that referenced this issue Aug 2, 2023
@JmPotato @rleungx
pd-ctl, tests: impl the merge all keyspace groups command (tikv#6782)
5013f49 
close tikv#6756

- Impl the merge all keyspace groups command.
- Further reuse of TSO cluster-related test code.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato JmPotato mentioned this issue Aug 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/keyspace Key space. component/tso Timestamp Oracle. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pd-ctl, tests: impl the merge all keyspace groups command JmPotato/pd
1 participant
@JmPotato