Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pdctl: escape the key before query the corresponding region #1299

Merged
merged 3 commits into from
Oct 29, 2018
Merged

pdctl: escape the key before query the corresponding region #1299

merged 3 commits into from
Oct 29, 2018

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Oct 26, 2018

What problem does this PR solve?

We should escape the key otherwise will not get the corresponding region.

What is changed and how it works?

escape the key in query URL.

Check List

Tests

  • Unit test

@rleungx rleungx mentioned this pull request Oct 26, 2018
Merged
@nolouch nolouch changed the title pd-ctl: escape the key before query the corresponding region pdctl: escape the key before query the corresponding region Oct 26, 2018
@nolouch nolouch added the type/bug The issue is confirmed as a bug. label Oct 26, 2018
@nolouch nolouch merged commit 4cdbcca into tikv:master Oct 29, 2018
@nolouch nolouch deleted the escape-key branch October 29, 2018 03:06
@disksing disksing added the needs-cherry-pick-release-2.1 The PR needs to cherry pick to release-2.1 branch. label Nov 7, 2018
disksing pushed a commit to oh-my-tidb/pd that referenced this pull request Nov 8, 2018
@nolouch @disksing
pd-ctl: escape the key before query the corresponding region (tikv#1299)
2ea58d1
@disksing disksing mentioned this pull request Nov 8, 2018
Merged
disksing added a commit that referenced this pull request Nov 8, 2018
@disksing
pdctl: cherry pick bugfixes (#1314)
e27a7de 
* pdctl: fix region key problems in detach mode (#1298)

* pd-ctl: escape the key before query the corresponding region (#1299)

* pdctl: fix decode key (#1308)

Signed-off-by: disksing <i@disksing.com>
@nolouch nolouch added the needs-cherry-pick-release-2.0 The PR needs to cherry pick to release-2.0 branch. label Nov 13, 2018
disksing added a commit to oh-my-tidb/pd that referenced this pull request Nov 14, 2018
@disksing
pdctl: cherry pick bugfixes (tikv#1298, tikv#1299, tikv#1308)
69d2d99
@disksing disksing mentioned this pull request Nov 14, 2018
Merged
disksing added a commit that referenced this pull request Nov 14, 2018
@disksing
Cherry pick bug fixes to release-2.0 (#1324)
db60f2c 
* server, client: fix hanging problem when etcd failed to start (#1267)

* server: use same initialcluster config to restart joined member (#1279)

* fix server build

* pdctl: cherry pick bugfixes (#1298, #1299, #1308)

* server/api: fix the issue about `regions/check` API (#1311)

* fix join build

* fix pdctl build

* fix region test

* fix warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disksing disksing disksing approved these changes

@rleungx rleungx rleungx approved these changes

@liukun4515 liukun4515 Awaiting requested review from liukun4515

Assignees
No one assigned
Labels
needs-cherry-pick-release-2.0 The PR needs to cherry pick to release-2.0 branch. needs-cherry-pick-release-2.1 The PR needs to cherry pick to release-2.1 branch. type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nolouch @disksing @rleungx