Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: update gofail to fix CI #1399

Merged
merged 7 commits into from
Dec 28, 2018
Merged

*: update gofail to fix CI #1399

merged 7 commits into from
Dec 28, 2018

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Dec 26, 2018 •
edited
Loading

What problem does this PR solve?

The tests failed which is caused by replace in go.mod.

What is changed and how it works?

This PR fixes CI after splitting tests into multi-container to run.

Check List

Tests

  • Unit test

@rleungx rleungx added the DNM label Dec 26, 2018
@rleungx
tiny fix
0a9c661 
Signed-off-by: rleungx <rleungx@gmail.com>
@rleungx
Copy link
Member Author

rleungx commented Dec 26, 2018

/run-unit-test

@rleungx
Copy link
Member Author

rleungx commented Dec 26, 2018

/rebuild

@rleungx rleungx changed the title *: only for testing CI *: update gofail to fix CI Dec 26, 2018
@rleungx rleungx removed the DNM label Dec 26, 2018
@rleungx
Copy link
Member Author

rleungx commented Dec 26, 2018

/run-unit-test

@rleungx rleungx requested a review from nolouch December 26, 2018 09:01
@rleungx
Copy link
Member Author

rleungx commented Dec 26, 2018

/run-unit-test

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@445871d). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1399   +/-   ##
=========================================
  Coverage          ?   75.45%           
=========================================
  Files             ?      135           
  Lines             ?    13068           
  Branches          ?        0           
=========================================
  Hits              ?     9860           
  Misses            ?     2315           
  Partials          ?      893

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 445871d...2f642a7. Read the comment docs.

huachaohuang
huachaohuang approved these changes Dec 28, 2018
View reviewed changes
Copy link
Contributor

@huachaohuang huachaohuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huachaohuang huachaohuang merged commit aaa7bb3 into tikv:master Dec 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huachaohuang huachaohuang huachaohuang approved these changes

@nolouch nolouch nolouch approved these changes

@disksing disksing Awaiting requested review from disksing

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rleungx @codecov-io @nolouch @huachaohuang