Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server/leader: use the compact revision to watch leader (#1396) #1404

Merged
merged 1 commit into from
Jan 9, 2019

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Jan 3, 2019

  • server/leader: use the compact revision to watch leader

What problem does this PR solve?

Cherry pick #1396 to 2.1 branch.

* server/leader: use the compact revision to watch leader

Signed-off-by: nolouch <nolouch@gmail.com>
@nolouch
Copy link
Contributor Author

nolouch commented Jan 3, 2019

/run-all-tests tidb=release-2.1 tikv=release-2.1 tidb-test=release-2.1

@huachaohuang
Copy link
Contributor

Tests failed.

@zhouqiang-cl
Copy link
Contributor

/rebuild

Copy link
Contributor

@siddontang siddontang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
But CI failed.

@zhouqiang-cl
Copy link
Contributor

/run-all-tests tidb=release-2.1 tikv=release-2.1 tidb-test=release-2.1

Copy link
Contributor

@huachaohuang huachaohuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@nolouch please work with @zhouqiang-cl to get the CI pass.

@zhouqiang-cl
Copy link
Contributor

I have migrate the old jenkins to new jenkins. we need to keep both run for a week. Now I am dig into why old jenkins failed

@zhouqiang-cl
Copy link
Contributor

/run-all-tests tidb=release-2.1 tikv=release-2.1 tidb-test=pr/714

@rleungx rleungx merged commit b1a419a into tikv:release-2.1 Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants