Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: turn the default limit of the hot region schedule #1616

Merged
merged 4 commits into from
Jul 4, 2019

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Jul 3, 2019

Signed-off-by: nolouch nolouch@gmail.com

What problem does this PR solve?

now, the balance-region-limit already enlarge, also make hot-region-schedule-limit more suitable.

What is changed and how it works?

enlarge limit.

Check List

Tests

  • Unit test
  • Integration test

Signed-off-by: nolouch <nolouch@gmail.com>
@nolouch nolouch added the needs-cherry-pick-release-3.0 The PR needs to cherry pick to release-3.0 branch. label Jul 3, 2019
Signed-off-by: nolouch <nolouch@gmail.com>
@disksing
Copy link
Contributor

disksing commented Jul 4, 2019

Should it be mentioned in release note? Because users need to manually update config value for old clusters.

@nolouch
Copy link
Contributor Author

nolouch commented Jul 4, 2019

@disksing Yes, we should. also, update the 3.0 upgrade guide.

Copy link
Contributor

@shafreeck shafreeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nolouch nolouch added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 4, 2019
@nolouch nolouch merged commit bfcee70 into tikv:master Jul 4, 2019
@nolouch nolouch deleted the fix-conf branch July 4, 2019 08:34
rleungx pushed a commit to rleungx/pd that referenced this pull request Jul 10, 2019
* config: turn the default limit of the hot region schedule

Signed-off-by: nolouch <nolouch@gmail.com>
@rleungx rleungx mentioned this pull request Jul 10, 2019
4 tasks
nolouch pushed a commit that referenced this pull request Jul 11, 2019
* schedulers: balance region consider pending peer (#1617)

* schedulers: balance region consider pending peers

Signed-off-by: nolouch <nolouch@gmail.com>

* scheduler: check replica for hot region  (#1609)

* check replica for hot region scheduler

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* schedule: set influence according to region size (#1613)

* not consider store limit when executing merge

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* set influence according to region size

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* fix race problems

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* config: turn the default limit of the hot region schedule (#1616)

* config: turn the default limit of the hot region schedule

Signed-off-by: nolouch <nolouch@gmail.com>

* update CHANGELOG

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-3.0 The PR needs to cherry pick to release-3.0 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants