Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pd-ctl echo output #1765

Merged
merged 2 commits into from
Sep 24, 2019
Merged

Fix pd-ctl echo output #1765

merged 2 commits into from
Sep 24, 2019

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Sep 23, 2019 •
edited
Loading

What problem does this PR solve?

Repair echo .

Before:

» schedule add label-scheduler
Success!
» schedule remove label-scheduler
»

After:

» schedule add label-scheduler
Success!
» schedule remove label-scheduler
Success!
»

Check List

Tests

  • Unit test

@lhy1024
add pd-ctl echo
7e26c9b 
Signed-off-by: lhy1024 <admin@liudos.us>
@codecov-io
Copy link

codecov-io commented Sep 23, 2019 •
edited
Loading

Codecov Report

Merging #1765 into master will increase coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1765      +/-   ##
==========================================
+ Coverage   77.26%   77.41%   +0.14%     
==========================================
  Files         163      163              
  Lines       16417    16430      +13     
==========================================
+ Hits        12685    12719      +34     
+ Misses       2683     2676       -7     
+ Partials     1049     1035      -14
Impacted Files Coverage Δ
tools/pd-ctl/pdctl/command/scheduler.go 67.01% <100%> (+3.79%) ⬆️
tools/pd-ctl/pdctl/command/operator.go 68.42% <100%> (+1.25%) ⬆️
tests/pdctl/helper.go 100% <100%> (ø) ⬆️
server/member/leader.go 73.46% <0%> (-6.64%) ⬇️
server/coordinator.go 78.78% <0%> (-6.44%) ⬇️
server/schedulers/random_merge.go 62.5% <0%> (-5%) ⬇️
client/client.go 68.6% <0%> (-1.94%) ⬇️
server/cluster.go 84.29% <0%> (-0.26%) ⬇️
server/server.go 82.79% <0%> (+0.57%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c648dc...159c33e. Read the comment docs.

@nolouch nolouch added type/bug The issue is confirmed as a bug. needs-cherry-pick-release-2.1 The PR needs to cherry pick to release-2.1 branch. needs-cherry-pick-release-3.0 The PR needs to cherry pick to release-3.0 branch. needs-cherry-pick-release-3.1 The PR needs to cherry pick to release-3.1 branch. labels Sep 23, 2019
@rleungx
Copy link
Member

rleungx commented Sep 24, 2019

How about adding some tests?

@lhy1024
add unit test
159c33e 
Signed-off-by: lhy1024 <admin@liudos.us>
@nolouch nolouch added the status/can-merge Indicates a PR has been approved by a committer. label Sep 24, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 24, 2019

/run-all-tests

@sre-bot sre-bot merged commit c973515 into tikv:master Sep 24, 2019
@lhy1024 lhy1024 deleted the pd-ctl-fix-echo branch September 24, 2019 07:08
@sre-bot
Copy link
Contributor

sre-bot commented Sep 24, 2019

cherry pick to release-3.0 failed

@sre-bot
Copy link
Contributor

sre-bot commented Sep 24, 2019

cherry pick to release-3.1 failed

@sre-bot
Copy link
Contributor

sre-bot commented Sep 24, 2019

cherry pick to release-2.1 failed

@lhy1024
Copy link
Contributor Author

lhy1024 commented Sep 25, 2019

/run-cherry-picker

lhy1024 added a commit to lhy1024/pd that referenced this pull request Sep 26, 2019
@lhy1024
Fix pd-ctl echo output (tikv#1765)
c0217dc 
Signed-off-by: lhy1024 <admin@liudos.us>

(cherry picked from commit c973515)
Signed-off-by: lhy1024 <admin@liudos.us>
@lhy1024 lhy1024 mentioned this pull request Sep 26, 2019
Merged
lhy1024 added a commit to lhy1024/pd that referenced this pull request Sep 26, 2019
@lhy1024
Fix pd-ctl echo output (tikv#1765)
427aa11 
Signed-off-by: lhy1024 <admin@liudos.us>

(cherry picked from commit c973515)
Signed-off-by: lhy1024 <admin@liudos.us>
lhy1024 added a commit to lhy1024/pd that referenced this pull request Sep 26, 2019
@lhy1024
Fix pd-ctl echo output (tikv#1765)
49297a2 
Signed-off-by: lhy1024 <admin@liudos.us>

(cherry picked from commit c973515)
Signed-off-by: lhy1024 <admin@liudos.us>
@lhy1024 lhy1024 mentioned this pull request Sep 26, 2019
Merged
lhy1024 added a commit to lhy1024/pd that referenced this pull request Sep 26, 2019
@lhy1024
Fix pd-ctl echo output (tikv#1765)
0d6941d 
Signed-off-by: lhy1024 <admin@liudos.us>

(cherry picked from commit c973515)
Signed-off-by: lhy1024 <admin@liudos.us>
@lhy1024 lhy1024 mentioned this pull request Sep 26, 2019
Merged
sre-bot pushed a commit that referenced this pull request Sep 30, 2019
@lhy1024 @sre-bot
pd-ctl: fix output (#1765) (#1763) (cherry pick to release-3.0) (#1770)
e774b2f 
Signed-off-by: lhy1024 <admin@liudos.us>
sre-bot pushed a commit that referenced this pull request Oct 2, 2019
@lhy1024 @sre-bot
pd-ctl: fix output (#1765) (#1763) (cherry pick to release-3.1) (#1771)
8e90d1a 
Signed-off-by: lhy1024 <admin@liudos.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disksing disksing disksing approved these changes

@nolouch nolouch nolouch approved these changes

@rleungx rleungx Awaiting requested review from rleungx

Assignees
No one assigned
Labels
needs-cherry-pick-release-2.1 The PR needs to cherry pick to release-2.1 branch. needs-cherry-pick-release-3.0 The PR needs to cherry pick to release-3.0 branch. needs-cherry-pick-release-3.1 The PR needs to cherry pick to release-3.1 branch. status/can-merge Indicates a PR has been approved by a committer. type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lhy1024 @codecov-io @rleungx @sre-bot @nolouch @disksing