Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: some picks to release 3.0 #1811

Merged
merged 2 commits into from
Oct 16, 2019
Merged

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Oct 16, 2019

What problem does this PR solve?

The failed cherry-pick:

What is changed and how it works?

cherry-pick
pick some fix to release 3.0

Check List

Tests

  • Unit test

Signed-off-by: nolouch <nolouch@gmail.com>
@nolouch
Copy link
Contributor Author

nolouch commented Oct 16, 2019

/run-all-tests

Copy link
Contributor

@lhy1024 lhy1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nolouch nolouch added the status/can-merge Indicates a PR has been approved by a committer. label Oct 16, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 16, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Oct 16, 2019

@nolouch merge failed.

@nolouch
Copy link
Contributor Author

nolouch commented Oct 16, 2019

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Oct 16, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Oct 16, 2019

@nolouch merge failed.

@lhy1024
Copy link
Contributor

lhy1024 commented Oct 16, 2019

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Oct 16, 2019

/run-all-tests

@sre-bot sre-bot merged commit 5e1068f into tikv:release-3.0 Oct 16, 2019
nolouch added a commit to nolouch/pd that referenced this pull request Nov 12, 2019
Signed-off-by: nolouch <nolouch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants