Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator: remove unnecessary check in op_controller #1882

Merged
merged 6 commits into from
Nov 6, 2019

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Nov 4, 2019

Signed-off-by: lhy1024 admin@liudos.us

What problem does this PR solve?

It is unnecessary to check in NewUnfinishedOpInfluence and GetOpInfluence

Check List

Tests

  • Unit test

Signed-off-by: lhy1024 <admin@liudos.us>
@lhy1024 lhy1024 added the type/refactor The issue belongs to a refactor work. label Nov 4, 2019
Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
@codecov-io
Copy link

codecov-io commented Nov 4, 2019

Codecov Report

Merging #1882 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1882      +/-   ##
==========================================
- Coverage   77.42%   77.39%   -0.04%     
==========================================
  Files         164      164              
  Lines       16586    16578       -8     
==========================================
- Hits        12842    12830      -12     
  Misses       2730     2730              
- Partials     1014     1018       +4
Impacted Files Coverage Δ
server/schedule/operator_controller.go 91.07% <100%> (-0.16%) ⬇️
server/schedule/operator/operator.go 86.94% <100%> (+0.52%) ⬆️
server/kv/etcd_kv.go 72.72% <0%> (-9.1%) ⬇️
pkg/etcdutil/etcdutil.go 82.6% <0%> (-5.8%) ⬇️
server/tso/tso.go 76.11% <0%> (-3.74%) ⬇️
server/member/leader.go 76.53% <0%> (-2.05%) ⬇️
server/heartbeat_streams.go 69% <0%> (-1%) ⬇️
server/server.go 82.43% <0%> (-0.62%) ⬇️
server/grpc_service.go 59.05% <0%> (+1.29%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb56454...42da517. Read the comment docs.

Copy link
Contributor

@shafreeck shafreeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhy1024 lhy1024 added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 6, 2019
Copy link
Member

@rleungx rleungx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lhy1024
Copy link
Contributor Author

lhy1024 commented Nov 6, 2019

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 6, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 6, 2019

/run-all-tests

@sre-bot sre-bot merged commit a256162 into tikv:master Nov 6, 2019
@lhy1024 lhy1024 deleted the op-refactor branch December 5, 2019 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/refactor The issue belongs to a refactor work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants