server/tso: fix the panic issue when getTS in the follower #1930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nolouch <nolouch@gmail.com>
shafreeck
approved these changes
Nov 12, 2019
|
/run-all-tests |
lhy1024
reviewed
Nov 12, 2019
| @@ -265,9 +265,13 @@ func (t *TimestampOracle) GetRespTS(count uint32) (pdpb.Timestamp, error) { | |||
| return resp, errors.New("tso count should be positive") | |||
| } | |||
|
|
|||
| failpoint.Inject("skipRetryGetTS", func() { | |||
There was a problem hiding this comment.
can we add maxRetryCount to TimestampOracle to avoid using failpoint?
There was a problem hiding this comment.
Let's keep this variable unchanged inside bug fix firstly.
|
/release |
lhy1024
approved these changes
Nov 12, 2019
nolouch
added
the
needs-cherry-pick-release-3.1
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
cherry pick to release-3.1 failed |
nolouch
added a commit
to nolouch/pd
that referenced
this pull request
Nov 12, 2019
Signed-off-by: nolouch <nolouch@gmail.com>
nolouch
added a commit
that referenced
this pull request
Nov 15, 2019
nolouch
added a commit
to nolouch/pd
that referenced
this pull request
Nov 25, 2019
Signed-off-by: nolouch <nolouch@gmail.com>
nolouch
added a commit
to nolouch/pd
that referenced
this pull request
Dec 2, 2019
Signed-off-by: nolouch <nolouch@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: nolouch nolouch@gmail.com
What problem does this PR solve?
Details:
What is changed and how it works?
fix the nil pointer.
Check List
Tests