Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the performance of the HTTP API for getting all regions (#1970) #1987

Merged
merged 2 commits into from
Dec 6, 2019

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Dec 5, 2019

What problem does this PR solve?

cherry-pick #1970 to release-3.1

What is changed and how it works?

Optimize convertToAPIRegions and h.rd.JSON

Check List

Tests

  • Unit test

Related changes

  • Need to be included in the release notes

@rleungx rleungx added this to the v3.1.0-beta milestone Dec 5, 2019
@rleungx
Copy link
Member Author

rleungx commented Dec 5, 2019

/run-all-tests

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx
Copy link
Member Author

rleungx commented Dec 5, 2019

/run-all-tests

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release-3.1@7a83ca7). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##             release-3.1    #1987   +/-   ##
==============================================
  Coverage               ?   69.47%           
==============================================
  Files                  ?      171           
  Lines                  ?    16807           
  Branches               ?        0           
==============================================
  Hits                   ?    11677           
  Misses                 ?     4143           
  Partials               ?      987
Impacted Files Coverage Δ
server/core/region.go 93.39% <100%> (ø)
server/api/router.go 100% <100%> (ø)
server/api/region.go 66.8% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a83ca7...c22b941. Read the comment docs.

@lhy1024
Copy link
Contributor

lhy1024 commented Dec 5, 2019

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 5, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 5, 2019

/run-all-tests

@rleungx rleungx removed the status/can-merge Indicates a PR has been approved by a committer. label Dec 5, 2019
@nolouch nolouch merged commit a25811a into tikv:release-3.1 Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants