schedule: fix panic caused by removing tombstone (#2015) #2037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Leung <rleungx@gmail.com>
|
/run-all-tests |
|
/run-all-tests |
2 similar comments
|
/run-all-tests |
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## release-3.1 #2037 +/- ##
==============================================
Coverage ? 69.47%
==============================================
Files ? 171
Lines ? 16819
Branches ? 0
==============================================
Hits ? 11685
Misses ? 4152
Partials ? 982
Continue to review full report at Codecov.
|
nolouch
approved these changes
Dec 18, 2019
shafreeck
approved these changes
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
cherry-pick #2015 to release-3.1 branch
What is changed and how it works?
This PR fixes the panic problem by resetting the attached function when removing the store limit.
Check List
Tests
Related changes