Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix the issue that loadcluster does not remove overlap regions(#2022) #2039

Merged
merged 2 commits into from
Dec 19, 2019

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Dec 18, 2019

Signed-off-by: nolouch nolouch@gmail.com

What problem does this PR solve?

cherry-pick #2022

What is changed and how it works?

cherry-pick.

Check List

Tests

  • Unit test

@nolouch nolouch added this to the v3.1.0-beta milestone Dec 18, 2019
@nolouch
Copy link
Contributor Author

nolouch commented Dec 18, 2019

/run-all-tests

@rleungx
Copy link
Member

rleungx commented Dec 18, 2019

/run-all-tests

@nolouch
Copy link
Contributor Author

nolouch commented Dec 18, 2019

/run-all-tests

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release-3.1@58ed361). Click here to learn what that means.
The diff coverage is 91.17%.

Impacted file tree graph

@@              Coverage Diff               @@
##             release-3.1    #2039   +/-   ##
==============================================
  Coverage               ?   69.47%           
==============================================
  Files                  ?      171           
  Lines                  ?    16837           
  Branches               ?        0           
==============================================
  Hits                   ?    11698           
  Misses                 ?     4157           
  Partials               ?      982
Impacted Files Coverage Δ
server/handler.go 51.98% <ø> (ø)
server/core/errors.go 62.5% <100%> (ø)
server/core/region_kv.go 82.95% <100%> (ø)
server/core/kv.go 76.08% <100%> (ø)
server/core/region.go 93.42% <100%> (ø)
server/core/basic_cluster.go 93.1% <83.33%> (ø)
server/cluster_info.go 88.07% <92.3%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58ed361...83daf86. Read the comment docs.

Copy link
Member

@AndreMouche AndreMouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndreMouche AndreMouche merged commit ce91ee9 into tikv:release-3.1 Dec 19, 2019
@nolouch nolouch deleted the fix-loadregion-3.1 branch December 19, 2019 02:51
@nolouch nolouch added the needs-cherry-pick-release-3.0 The PR needs to cherry pick to release-3.0 branch. label Dec 19, 2019
@nolouch
Copy link
Contributor Author

nolouch commented Dec 19, 2019

/run-cherry-picker

@sre-bot
Copy link
Contributor

sre-bot commented Dec 19, 2019

cherry pick to release-3.0 in PR #2040

sre-bot added a commit that referenced this pull request Dec 19, 2019
nolouch added a commit to nolouch/pd that referenced this pull request Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-3.0 The PR needs to cherry pick to release-3.0 branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants