scheduelrs: add load expectations for hot scheudler #2297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nolouch <nolouch@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2297 +/- ##
==========================================
+ Coverage 76.25% 76.56% +0.30%
==========================================
Files 199 201 +2
Lines 21591 21803 +212
==========================================
+ Hits 16464 16693 +229
+ Misses 3891 3883 -8
+ Partials 1236 1227 -9
Continue to review full report at Codecov.
|
rleungx
reviewed
Mar 28, 2020
| @@ -42,6 +42,7 @@ func initHotRegionScheduleConfig() *hotRegionSchedulerConfig { | |||
| GreatDecRatio: 0.95, | |||
| MinorDecRatio: 0.99, | |||
| MaxPeerNum: 1000, | |||
| ToleranceRatio: 1.02, | |||
pkg/mock/mockcluster/mockcluster.go
Outdated
| @@ -420,10 +426,13 @@ func (mc *Cluster) UpdateStorageReadBytes(storeID uint64, bytesRead uint64) { | |||
| } | |||
|
|
|||
| // UpdateStorageWrittenKeys updates store written keys. | |||
| func (mc *Cluster) UpdateStorageWrittenKeys(storeID uint64, keysWritten uint64) { | |||
| func (mc *Cluster) UpdateStorageWrittenKeys(storeID uint64, keysWritten uint64, updateSingleOption ...struct{}) { | |||
There was a problem hiding this comment.
How about:
Suggested change
| func (mc *Cluster) UpdateStorageWrittenKeys(storeID uint64, keysWritten uint64, updateSingleOption ...struct{}) { | |
| func (mc *Cluster) UpdateStorageWrittenStats(storeID uint64, keysWritten uint64, bytesWritten uint64) { |
lhy1024
reviewed
Mar 28, 2020
| // Only consider about count and key rate. | ||
| if srcLd.Count > dstLd.Count && | ||
| srcLd.KeyRate >= dstLd.KeyRate+peer.GetKeyRate() { | ||
| // Only consider about key rate. |
There was a problem hiding this comment.
The srcCount may higher but the keyRate lower.
lhy1024
approved these changes
Mar 28, 2020
Signed-off-by: nolouch <nolouch@gmail.com>
rleungx
approved these changes
Mar 28, 2020
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
@nolouch merge failed. |
|
/merge |
|
/run-all-tests |
|
@nolouch merge failed. |
|
/merge |
|
/run-all-tests |
|
@nolouch merge failed. |
|
/run-all-tests |
hsqlu
pushed a commit
to hsqlu/pd
that referenced
this pull request
Mar 29, 2020
* scheduelrs: add load expectations for hot scheudler Signed-off-by: nolouch <nolouch@gmail.com>
nolouch
added a commit
to nolouch/pd
that referenced
this pull request
Apr 10, 2020
* scheduelrs: add load expectations for hot scheudler Signed-off-by: nolouch <nolouch@gmail.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: nolouch nolouch@gmail.com
What problem does this PR solve?
To prevent excessive redundant scheduling
What is changed and how it works?
add the avg load as an expectation.
Release note
Check List
Tests
the scheduler operator is reduced and QPS is stable.