Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schedulers: adjust calculate rank process #2314

Merged
merged 3 commits into from
Apr 2, 2020
Merged

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Apr 1, 2020

Signed-off-by: nolouch nolouch@gmail.com

What problem does this PR solve?

Fix the problem that read hotspot scheduling cannot converge well.
image

What is changed and how it works?

  • adjust the method of calculate rank process. (SrcStore consider the peer)
  • adjust the size of the window of reading statistic

Release note

Fix the problem that read hotspot scheduling cannot converge well.

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)
    image
    image

Signed-off-by: nolouch <nolouch@gmail.com>
@nolouch nolouch added priority/P0 The issue has P0 priority. component/schedule Scheduling logic. labels Apr 1, 2020
@nolouch nolouch added this to the v4.0.0-rc milestone Apr 1, 2020
@nolouch nolouch requested review from lhy1024 and rleungx April 1, 2020 20:56
Signed-off-by: nolouch <nolouch@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #2314 into master will decrease coverage by 0.19%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2314      +/-   ##
==========================================
- Coverage   77.10%   76.91%   -0.20%     
==========================================
  Files         203      203              
  Lines       22277    22249      -28     
==========================================
- Hits        17177    17113      -64     
- Misses       3803     3829      +26     
- Partials     1297     1307      +10     
Impacted Files Coverage Δ
server/schedulers/hot_region.go 82.39% <66.66%> (-0.10%) ⬇️
server/statistics/store.go 71.01% <100.00%> (ø)
tools/pd-backup/pdbackup/backup.go 0.00% <0.00%> (-39.40%) ⬇️
server/schedulers/shuffle_hot_region.go 63.96% <0.00%> (-9.91%) ⬇️
server/region_syncer/client.go 79.38% <0.00%> (-6.88%) ⬇️
server/heartbeat_streams.go 67.00% <0.00%> (-6.00%) ⬇️
server/schedulers/random_merge.go 61.19% <0.00%> (-2.99%) ⬇️
server/member/leader.go 73.10% <0.00%> (-2.53%) ⬇️
pkg/mock/mockhbstream/mockhbstream.go 89.23% <0.00%> (-1.54%) ⬇️
pkg/etcdutil/etcdutil.go 82.60% <0.00%> (-1.45%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a801ed...d6aac7f. Read the comment docs.

@nolouch nolouch modified the milestones: v4.0.0-rc, v2.0.12, v4.0.0-ga Apr 2, 2020
Signed-off-by: nolouch <nolouch@gmail.com>
@lhy1024
Copy link
Contributor

lhy1024 commented Apr 2, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 2, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 2, 2020

/run-all-tests

Copy link
Member

@HunDunDM HunDunDM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sre-bot sre-bot merged commit 2b542f4 into tikv:master Apr 2, 2020
@nolouch nolouch deleted the adjust-rank branch April 2, 2020 03:55
@nolouch nolouch modified the milestones: v4.0.0-rc, v3.1.0-ga Apr 10, 2020
nolouch added a commit to nolouch/pd that referenced this pull request Apr 10, 2020
Signed-off-by: nolouch <nolouch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/schedule Scheduling logic. priority/P0 The issue has P0 priority. status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants