Store label limit #2674
Store label limit #2674
Conversation
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| if keyOk { | ||
| if limit, err := h.GetLabelStoresLimit(label, 0); err != nil { | ||
| return | ||
| } else { |
There was a problem hiding this comment.
if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
| @@ -1695,6 +1695,21 @@ func (c *RaftCluster) GetStoreLimitByType(storeID uint64, typ storelimit.Type) f | |||
| return c.opt.GetStoreLimitByType(storeID, typ) | |||
| } | |||
|
|
|||
| func (c *RaftCluster) GetLabelStores(label config.StoreLabel) []uint64 { | |||
There was a problem hiding this comment.
exported method RaftCluster.GetLabelStores should have comment or be unexported
| if keyOk { | ||
| if limit, err := h.GetLabelStoresLimit(label, 0); err != nil { | ||
| return | ||
| } else { |
There was a problem hiding this comment.
if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
| // IsTiFlashStore used to judge flash store. | ||
| // FIXME: remove the hack way | ||
| func IsTiFlashStore(store *metapb.Store) bool { | ||
| // Judge if it needs placement rule. |
There was a problem hiding this comment.
comment on exported function IsPlacementNeeded should be of the form "IsPlacementNeeded ..."
| func (o *PersistOptions) GetLabelStoresLimit(label StoreLabel) StoreLimitConfig { | ||
| if l, ok := o.GetScheduleConfig().StoreLabelLimit[label.String()]; !ok { | ||
| return l | ||
| } else { |
There was a problem hiding this comment.
if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
| @@ -1695,6 +1695,21 @@ func (c *RaftCluster) GetStoreLimitByType(storeID uint64, typ storelimit.Type) f | |||
| return c.opt.GetStoreLimitByType(storeID, typ) | |||
| } | |||
|
|
|||
| func (c *RaftCluster) GetLabelStores(label config.StoreLabel) []uint64 { | |||
There was a problem hiding this comment.
exported method RaftCluster.GetLabelStores should have comment or be unexported
| @@ -419,6 +429,15 @@ func (h *Handler) SetAllStoresLimit(ratePerMin float64, limitType storelimit.Typ | |||
| return nil | |||
| } | |||
|
|
|||
| // GetAllStoresLimit is used to get limit of all stores. | |||
There was a problem hiding this comment.
comment on exported method Handler.GetLabelStoresLimit should be of the form "GetLabelStoresLimit ..."
What problem does this PR solve?
Solve issue #2568
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release note